Added tagging logic for debian-base to support both Stretch and Buster build tags.#25
Merged
dschaper merged 1 commit intopi-hole:masterfrom May 26, 2020
Conversation
Member
Author
|
The way the Debian tags are split out, we could actually add a |
dschaper
approved these changes
May 26, 2020
diginc
approved these changes
May 26, 2020
Member
Author
|
Woohoo! There is now a |
Member
|
Thank you! |
Member
Author
|
Not sure if circle CI is still running? Maybe it should be disabled? |
Member
|
There's no checks for it? Might be an automated build from docker hub though |
Member
|
I've unfollowed this repo on Circle, it should stop building. It was building Could remove the yaml if it's not needed anymore. |
Member
|
Actually, we need CircleCI for ftl builds I believe. Will PR the removal of only the base images. |
Merged
Member
|
Everything can go actually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tagging logic for
debian-baseimages to support both Stretch and Buster build tags.debian-baseimage as the downstreamdocker-pi-holewould be affected if the image were immediately cut over to Buster.debian-base:lastestimage.debian-base:latest(on master - stretch for now)debian-base:stretch(on master)debian-base:buster(on master)debian-base:{tag}(branch doesn't matter - stretch for now)debian-base:{tag}-stretch(branch doesn't matter)debian-base:{tag}-buster(branch doesn't matter)debian-base:{branch}(stretch for now)debian-base:{branch}-stretchdebian-base:{branch}-busterWant to test this?
docker-compose buildDRY_RUN=true ./tag-and-push.sh {docker-compose service name}to see what the resulting tags are, example:DRY_RUN=true ./tag-and-push.sh debian-base-stretch.