Try to bring back support for riscv64 #634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a copy of the "Build and Push" step and add an extra build argument for the riscv64 architecture to override the repository of the "BASE_IMAGE".
Collaborator
|
The CI is not setup for PRs so unfortunately I cannot trigger it for checking if it builds.. |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Followup for #633 (comment)
This PR is an attempt to bring back riscv64 support that I removed in #633 to fix the build for the "main" platforms.
Use a copy of the "Build and Push" step and add an extra build argument for the riscv64 architecture to override the repository of the "BASE_IMAGE".
Splitting the build steps and pushing "individually" may or may not break the tags.
It is worth noting that the
riscv64/ubuntu:22.04image was last built in December 2022, so more than a year ago. It does not look supported anymore.cc @olof-nord
Benefits
Restored riscv64 support
Possible drawbacks
Additional maintenance from duplicate step/more complex build pipeline.
Applicable issues
Followup for #633 (comment)
Additional information
No tested. Can you trigger a build on the PR?