fix modulo operator, when handling integer-ranges without 0#630
Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom Aug 20, 2021
Merged
fix modulo operator, when handling integer-ranges without 0#630ondrejmirtes merged 2 commits intophpstan:masterfrom
ondrejmirtes merged 2 commits intophpstan:masterfrom
Conversation
Member
|
Perfect, thank you! |
Contributor
Author
the least I could do to give back, since I received so much support in the PRs I submitted lately <3. thank you again! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#5492
it was a bit supprising that
IntegerRange::fromInterval()can return aNeverTypeinphpstan-src/src/Type/IntegerRangeType.php
Lines 31 to 33 in 2f991d1
this adds the necessary conditions to handle the case