Consider numeric-string types after string concat #3117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jun 3, 2024
ondrejmirtes
requested changes
Jun 3, 2024
|
|
||
| if ( | ||
| !is_numeric($rightConstantString->getValue()) | ||
| || str_contains($rightConstantString->getValue(), '.') |
Member
There was a problem hiding this comment.
I'd rather only include int-like strings rather than exclude strings with .. Look at these fuckers: https://3v4l.org/Ia4r0
Contributor
Author
There was a problem hiding this comment.
another great catch. fixed - thanks.
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving concat types related to phpstan/phpstan#11129
while implementing I realized that the actual root-cause for 11129 is likely related to some loop related types, not the concat typing alone.
I currently have no plans to look into the loop related parts, therefore submitting this typing enhancements alone. this means this PR will not close Bug 11129.