Bleeding edge - More precise flock() operation flags#2477
Merged
ondrejmirtes merged 2 commits intophpstan:1.10.xfrom Jun 22, 2023
Merged
Bleeding edge - More precise flock() operation flags#2477ondrejmirtes merged 2 commits intophpstan:1.10.xfrom
ondrejmirtes merged 2 commits intophpstan:1.10.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
staabm
commented
Jun 22, 2023
Contributor
Author
There was a problem hiding this comment.
ondrejmirtes
requested changes
Jun 22, 2023
staabm
commented
Jun 22, 2023
Contributor
Author
There was a problem hiding this comment.
semantically we can be more precise if we want. as not all combinations of the constants are allowed.
0 is not allowed.
combinations of e.g. LOCK_EX and LOCK_SH are not valid
not sure its worth it though
Member
There was a problem hiding this comment.
Can you use the constants instead of numbers?
Contributor
Author
There was a problem hiding this comment.
it seems we do not yet support constants in int-mask:
Contributor
Author
There was a problem hiding this comment.
clxmstaab
force-pushed
the
flock
branch
2 times, most recently
from
bc4eed5 to
2316434
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.