Draft: hide class-level template types from static members#2232
Open
jiripudil wants to merge 5 commits intophpstan:1.10.xfrom
Open
Draft: hide class-level template types from static members#2232jiripudil wants to merge 5 commits intophpstan:1.10.xfrom
jiripudil wants to merge 5 commits intophpstan:1.10.xfrom
Conversation
Member
|
Added a few commits so that this is ready for static methods if we decide to go with it :) But yeah, the CarFactoryProcessor example is somewhat reasonable even for static method. About static properties - yeah, that might not be trivial at all :/ Because when retrieving PHPDocs, FileTypeMapper is handed these parameters: public function getResolvedPhpDoc(
?string $fileName,
?string $className,
?string $traitName,
?string $functionName,
string $docComment,
): ResolvedPhpDocBlockWe don't know when we're getting a PHPDoc for a property, they're not stored separately :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solution I was talking about previously.
The failing test discovered exactly the kind of class-string magic I was afraid people might be doing. I don't know how many actual real-life use cases there are, but it puts doubt in my mind about this.
Nevertheless, I still firmly believe this is a must for static properties, which, sadly, I have no idea how to cover in this way.