Support contravariant template types#2051
Merged
ondrejmirtes merged 6 commits intophpstan:1.9.xfrom Dec 5, 2022
Merged
Conversation
ondrejmirtes
requested changes
Dec 5, 2022
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
I'd like some "accepts" tests, meaning "does this parameter accept this argument"? For example in CallMethodsRuleTest, to see that the objects behave correctly :)
Contributor
Author
|
I'm assuming you have something like this in mind? Otherwise, apart from a detail irrelevant to this case, |
Member
|
Yes, thank you :) |
|
Thank you for picking up on it @jiripudil :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#3960.
Basically, I'm picking up where #1492 left off, with a couple more tests.
Once this lands, I'd like to follow up with a fix to the bug mentioned in the original PR (#1492 (comment)). The logs are no longer available for the relevant builds, but I understand it caused some turmoil, and should therefore be discussed separately.