Improve impossible type checker for void-returning functions#1857
Improve impossible type checker for void-returning functions#1857ondrejmirtes merged 2 commits intophpstan:1.9.xfrom
Conversation
ondrejmirtes
left a comment
There was a problem hiding this comment.
Super-interesting! I'd probably put this behind a bleedingEdge toggle.
The @phpstan-assert functionality is enabled for everyone because it can be considered just a smarter type inference, but this bit feels a little bit extra and can result in some extra errors, so bleedingEdge would feel safer for me.
|
wow you were fast 🎉 |
|
@herndlm Yes, Richard expressed this concern earlier but I said to try it. That's why it's in bleedingEdge now only. |
4ae1f8f to
42daebe
Compare
|
@rvanvelzen I think this one is ready to merge. I really appreciate all the work you do, but I feel like you're overusing the Draft feature a bit :) I respect it and I wouldn't merge a PR in draft state, but sometimes I'm eager to merge something because to my eyes it seems totally fine, so don't hesitate to mark things as ready sooner. We can always fix this in the future. Another problem is that GitHub doesn't notify me when something's marked as ready so I added a workflow that adds a bot comment to such PRs: e3b9771 |
|
Thank you! |
Fix phpstan/phpstan#8169