Closed
Conversation
Member
|
Without a test this doesn't tell us anything 😊 |
Contributor
Author
|
Yeah I didn't succeed in creating one unfortunately. But in the linked PR I added the same thing and there it's needed. This is a hard one to argue about :/ |
Contributor
Author
|
I think the problem was that the never only happens inside the loop iteration and if I try to dump the type I only see the merged scopes where the never is eliminated. But in the other PR it is problematic because it is used via array_shift/pop and actually widens the type via the new methods. At least that's what I think so far. |
Member
|
So it's linked to the other PR. If you can't make its tests pass without this, it belongs there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the scope merge that all other loops have as well. Fixes the first failure mentioned in #1847 (comment)
I didn't understand it fully though tbh