Skip to content

serialize/unserialize is not allowed in enum#1643

Merged
ondrejmirtes merged 1 commit into
phpstan:1.8.xfrom
staabm:enum-serialize
Aug 25, 2022
Merged

serialize/unserialize is not allowed in enum#1643
ondrejmirtes merged 1 commit into
phpstan:1.8.xfrom
staabm:enum-serialize

Conversation

@staabm

@staabm staabm commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

Comment thread src/Rules/Classes/EnumSanityRule.php Outdated

@staabm staabm Aug 23, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php-parser considers these methods as magic starting with the next release with nikic/PHP-Parser#860

@staabm
staabm marked this pull request as ready for review August 25, 2022 06:13
@ondrejmirtes
ondrejmirtes merged commit 256e12a into phpstan:1.8.x Aug 25, 2022
@ondrejmirtes

Copy link
Copy Markdown
Member

Thank you.

@staabm
staabm deleted the enum-serialize branch August 25, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enum should error on magic methods

2 participants