XmlReader::next|read() has side-effects#1551
Merged
Merged
Conversation
staabm
marked this pull request as ready for review
July 25, 2022 19:07
ondrejmirtes
requested changes
Jul 25, 2022
ondrejmirtes
left a comment
ondrejmirtes
left a comment
Member
There was a problem hiding this comment.
- The error on line 39 here https://phpstan.org/r/0a7a5b40-8c5b-40af-bd7d-66cea71e8363 isn't tested
- Instead of rule-specific tests, NodeScopeResolverTest would be more fitting here.
Contributor
Author
|
thx, turned into a NodeScopeResolverTest |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#7689
see https://www.php.net/XmlReader