Specify explicit mixed array type via is_array#1191
Merged
ondrejmirtes merged 2 commits intophpstan:1.5.xfrom Apr 12, 2022
Merged
Specify explicit mixed array type via is_array#1191ondrejmirtes merged 2 commits intophpstan:1.5.xfrom
is_array#1191ondrejmirtes merged 2 commits intophpstan:1.5.xfrom
Conversation
herndlm
force-pushed
the
specify-explicit-mixed-array-type-via-is-array
branch
from
8ea5ad2 to
c880b7f
Compare
Member
|
My fear is that this will wreak havoc on level 9 codebases (https://github.com/phpstan/phpstan-src/runs/5891253618?check_suite_focus=true). I'd rather if the explicit mixed was passed only when bleedingEdge is enabled. |
Contributor
Author
|
Isn't that what level 9 is for? 😅 |
Member
|
Yeah but this situation can be seen as a new check: https://phpstan.org/user-guide/backward-compatibility-promise
|
Contributor
Author
|
Definitely |
Contributor
Author
|
I think this should be fine, let me know if there is more needed :) |
herndlm
force-pushed
the
specify-explicit-mixed-array-type-via-is-array
branch
from
3d73930 to
56207bd
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to phpstan/phpstan#7004
Fixes strict array shape / mixed handling with level 9, e.g. https://phpstan.org/r/77a8e65b-dd07-4c4b-bc8c-76a32243d553
The
discussion-7004.phpis not adhering to standards.. let me know if this should be renamed, or if I should create an issue or so.UPDATE: moved behind a feature toggle that is only enabled in bleedingEdge, as discussed, to avoid wreaking havoc on level 9 :)