implemented str_contains FunctionTypeSpecifyingExtension#1067
Closed
staabm wants to merge 7 commits intophpstan:1.4.xfrom
Closed
implemented str_contains FunctionTypeSpecifyingExtension#1067staabm wants to merge 7 commits intophpstan:1.4.xfrom
str_contains FunctionTypeSpecifyingExtension#1067staabm wants to merge 7 commits intophpstan:1.4.xfrom
Conversation
staabm
force-pushed
the
strfn-specifiying
branch
4 times, most recently
from
43ee591 to
4033f21
Compare
Contributor
|
Nice! The minute this is merged I'm going to add the correspondent phpstan-webmozart-assert support :) |
Member
|
Hi, if you base this on 1.4.x, it's gonna be released sooner 😊 |
Contributor
Author
|
Ohh I see. Thought 1.4.x is meant for bugfix only and 1.5.x for new features |
Member
|
That line is blurred here - you could look at this and consider it a bugfix too. |
staabm
force-pushed
the
strfn-specifiying
branch
from
4033f21 to
46a7c35
Compare
staabm
force-pushed
the
strfn-specifiying
branch
from
46a7c35 to
a6a4fed
Compare
Contributor
Author
|
mixed it up a bit. re-opened as a new PR for 1.4.x in #1068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first str-family-function to infer
non-empty-stringtype.Initially had the idea of putting everything into a single StrFamily* extension, but then figured that the semantics between substr, substring, strpos, stripos, str_contains etc are too different, and it would be more readable to put each of them into a separate extension.
therefore this is the first PR. if merged, I will work on similar semantics for the remaining functions
refs phpstan/phpstan#6792