Fix phpstan/phpstan#14312: Parameter #2 of array_key_exists expects array, non-empty-array given (#5237)

phpstan-bot · claude · staabm · web-flow · commit dd498a5131dc · 2026-03-17T17:08:40.000+01:00
Co-authored-by: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
Co-authored-by: Markus Staab &lt;markus.staab@redaxo.de&gt;
diff --git a/src/Type/Php/ArrayKeyExistsFunctionTypeSpecifyingExtension.php b/src/Type/Php/ArrayKeyExistsFunctionTypeSpecifyingExtension.php
@@ -78,9 +78,12 @@ public function specifyTypes(
 				$specifiedTypes = new SpecifiedTypes();
 
 				if (count($keyType->getConstantScalarTypes()) <= 1) {
+					$nonEmptyType = $arrayType->isArray()->yes()
+						? new NonEmptyArrayType()
+						: TypeCombinator::intersect(new ArrayType(new MixedType(), new MixedType()), new NonEmptyArrayType());
 					$specifiedTypes = $specifiedTypes->unionWith($this->typeSpecifier->create(
 						$array,
-						new NonEmptyArrayType(),
+						$nonEmptyType,
 						$context,
 						$scope,
 					));
diff --git a/src/Type/Php/ArraySearchFunctionTypeSpecifyingExtension.php b/src/Type/Php/ArraySearchFunctionTypeSpecifyingExtension.php
@@ -11,7 +11,10 @@
 use PHPStan\DependencyInjection\AutowiredService;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Type\Accessory\NonEmptyArrayType;
+use PHPStan\Type\ArrayType;
 use PHPStan\Type\FunctionTypeSpecifyingExtension;
+use PHPStan\Type\MixedType;
+use PHPStan\Type\TypeCombinator;
 use function strtolower;
 
 #[AutowiredService]
@@ -42,9 +45,14 @@ public function specifyTypes(
 			return new SpecifiedTypes();
 		}
 
+		$arrayType = $scope->getType($arrayArg);
+		$nonEmptyType = $arrayType->isArray()->yes()
+			? new NonEmptyArrayType()
+			: TypeCombinator::intersect(new ArrayType(new MixedType(), new MixedType()), new NonEmptyArrayType());
+
 		return $this->typeSpecifier->create(
 			$arrayArg,
-			new NonEmptyArrayType(),
+			$nonEmptyType,
 			$context,
 			$scope,
 		);
diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -2746,4 +2746,16 @@ public function testBug13247(): void
 		$this->analyse([__DIR__ . '/data/bug-13247.php'], []);
 	}
 
+	#[RequiresPhp('>= 8.0')]
+	public function testBug14312(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14312.php'], []);
+	}
+
+	#[RequiresPhp('>= 8.0')]
+	public function testBug14312b(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14312b.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Functions/data/bug-14312.php b/tests/PHPStan/Rules/Functions/data/bug-14312.php
@@ -0,0 +1,15 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14312;
+
+function get_something(): mixed { return null; }
+
+function test(string $a, string $b): bool {
+	$o = get_something();
+	if (array_key_exists($a, $o)) {
+		if (array_key_exists($b, $o)) {
+			return true;
+		}
+	}
+	return false;
+}
diff --git a/tests/PHPStan/Rules/Functions/data/bug-14312b.php b/tests/PHPStan/Rules/Functions/data/bug-14312b.php
@@ -0,0 +1,15 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14312b;
+
+function get_something(): mixed { return null; }
+
+function test(string $needle): bool {
+	$o = get_something();
+	if (array_search($needle, $o) !== false) {
+		if (array_search($needle, $o)) {
+			return true;
+		}
+	}
+	return false;
+}
