Smoother parallel process quitting when the child process crashes

ondrejmirtes · ondrejmirtes · commit cbbbd36189c5 · 2021-01-13T18:12:19.000+01:00
diff --git a/src/Parallel/ParallelAnalyser.php b/src/Parallel/ParallelAnalyser.php
@@ -76,7 +76,7 @@ public function analyse(
 				$process = $this->processPool->getProcess($identifier);
 				$process->bindConnection($decoder, $encoder);
 				if (count($jobs) === 0) {
-					$this->processPool->quitProcess($identifier);
+					$this->processPool->tryQuitProcess($identifier);
 					return;
 				}
 
@@ -174,7 +174,7 @@ public function analyse(
 				}
 
 				if (count($jobs) === 0) {
-					$this->processPool->quitProcess($processIdentifier);
+					$this->processPool->tryQuitProcess($processIdentifier);
 					return;
 				}
 
diff --git a/src/Parallel/ProcessPool.php b/src/Parallel/ProcessPool.php
@@ -41,7 +41,7 @@ public function tryQuitProcess(string $identifier): void
 		$this->quitProcess($identifier);
 	}
 
-	public function quitProcess(string $identifier): void
+	private function quitProcess(string $identifier): void
 	{
 		$process = $this->getProcess($identifier);
 		$process->quit();

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function analyse(`
`76`	`76`	`$process = $this->processPool->getProcess($identifier);`
`77`	`77`	`$process->bindConnection($decoder, $encoder);`
`78`	`78`	`if (count($jobs) === 0) {`
`79`		`- $this->processPool->quitProcess($identifier);`
	`79`	`+ $this->processPool->tryQuitProcess($identifier);`
`80`	`80`	`return;`
`81`	`81`	`}`
`82`	`82`
`@@ -174,7 +174,7 @@ public function analyse(`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`if (count($jobs) === 0) {`
`177`		`- $this->processPool->quitProcess($processIdentifier);`
	`177`	`+ $this->processPool->tryQuitProcess($processIdentifier);`
`178`	`178`	`return;`
`179`	`179`	`}`
`180`	`180`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function tryQuitProcess(string $identifier): void`
`41`	`41`	`$this->quitProcess($identifier);`
`42`	`42`	`}`
`43`	`43`
`44`		`- public function quitProcess(string $identifier): void`
	`44`	`+ private function quitProcess(string $identifier): void`
`45`	`45`	`{`
`46`	`46`	`$process = $this->getProcess($identifier);`
`47`	`47`	`$process->quit();`