Precise type for $matches from preg_match generally available, out of bleeding edge

ondrejmirtes · ondrejmirtes · commit bd2cec118592 · 2024-08-01T09:47:23.000+02:00
diff --git a/conf/bleedingEdge.neon b/conf/bleedingEdge.neon
@@ -54,7 +54,6 @@ parameters:
 		paramOutType: true
 		pure: true
 		checkParameterCastableToStringFunctions: true
-		narrowPregMatches: true
 		uselessReturnValue: true
 		printfArrayParameters: true
 		preciseMissingReturn: true
diff --git a/conf/config.neon b/conf/config.neon
@@ -89,7 +89,6 @@ parameters:
 		paramOutType: false
 		pure: false
 		checkParameterCastableToStringFunctions: false
-		narrowPregMatches: false
 		uselessReturnValue: false
 		printfArrayParameters: false
 		preciseMissingReturn: false
@@ -290,10 +289,6 @@ conditionalTags:
 		phpstan.parser.richParserNodeVisitor: %featureToggles.curlSetOptTypes%
 	PHPStan\Parser\TypeTraverserInstanceofVisitor:
 		phpstan.parser.richParserNodeVisitor: %featureToggles.instanceofType%
-	PHPStan\Type\Php\PregMatchTypeSpecifyingExtension:
-		phpstan.typeSpecifier.functionTypeSpecifyingExtension: %featureToggles.narrowPregMatches%
-	PHPStan\Type\Php\PregMatchParameterOutTypeExtension:
-		phpstan.functionParameterOutTypeExtension: %featureToggles.narrowPregMatches%
 
 services:
 	-
@@ -1491,6 +1486,16 @@ services:
 	-
 		class: PHPStan\Type\Php\PregMatchTypeSpecifyingExtension
 
+	-
+		class: PHPStan\Type\Php\PregMatchTypeSpecifyingExtension
+		tags:
+			- phpstan.typeSpecifier.functionTypeSpecifyingExtension
+
+	-
+		class: PHPStan\Type\Php\PregMatchParameterOutTypeExtension
+		tags:
+			- phpstan.functionParameterOutTypeExtension
+
 	-
 		class: PHPStan\Type\Php\PregMatchParameterOutTypeExtension
 
diff --git a/conf/parametersSchema.neon b/conf/parametersSchema.neon
@@ -84,7 +84,6 @@ parametersSchema:
 		paramOutType: bool()
 		pure: bool()
 		checkParameterCastableToStringFunctions: bool()
-		narrowPregMatches: bool()
 		uselessReturnValue: bool()
 		printfArrayParameters: bool()
 		preciseMissingReturn: bool()
