Fix PossiblyPureFuncCallCollector

ondrejmirtes · ondrejmirtes · commit 57b0ae06e2fa · 2024-04-17T22:20:19.000+02:00
diff --git a/src/Rules/DeadCode/PossiblyPureFuncCallCollector.php b/src/Rules/DeadCode/PossiblyPureFuncCallCollector.php
@@ -3,13 +3,13 @@
 namespace PHPStan\Rules\DeadCode;
 
 use PhpParser\Node;
-use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Stmt\Expression;
 use PHPStan\Analyser\Scope;
 use PHPStan\Collectors\Collector;
 use PHPStan\Reflection\ReflectionProvider;
 
 /**
- * @implements Collector<FuncCall, array{string, int}>
+ * @implements Collector<Node\Stmt\Expression, array{string, int}>
  */
 class PossiblyPureFuncCallCollector implements Collector
 {
@@ -20,20 +20,23 @@ public function __construct(private ReflectionProvider $reflectionProvider)
 
 	public function getNodeType(): string
 	{
-		return FuncCall::class;
+		return Expression::class;
 	}
 
 	public function processNode(Node $node, Scope $scope)
 	{
-		if (!$node->name instanceof Node\Name) {
+		if (!$node->expr instanceof Node\Expr\FuncCall) {
+			return null;
+		}
+		if (!$node->expr->name instanceof Node\Name) {
 			return null;
 		}
 
-		if (!$this->reflectionProvider->hasFunction($node->name, $scope)) {
+		if (!$this->reflectionProvider->hasFunction($node->expr->name, $scope)) {
 			return null;
 		}
 
-		$functionReflection = $this->reflectionProvider->getFunction($node->name, $scope);
+		$functionReflection = $this->reflectionProvider->getFunction($node->expr->name, $scope);
 		if (!$functionReflection->isPure()->maybe()) {
 			return null;
 		}
diff --git a/tests/PHPStan/Rules/DeadCode/data/call-to-function-without-impure-points.php b/tests/PHPStan/Rules/DeadCode/data/call-to-function-without-impure-points.php
@@ -31,4 +31,6 @@ function (): void {
 	funcWithRef();
 	impureFunc();
 	callingImpureFunc();
+
+	$a = myFunc();
 };

Original file line number	Diff line number	Diff line change
`@@ -3,13 +3,13 @@`
`3`	`3`	`namespace PHPStan\Rules\DeadCode;`
`4`	`4`
`5`	`5`	`use PhpParser\Node;`
`6`		`-use PhpParser\Node\Expr\FuncCall;`
	`6`	`+use PhpParser\Node\Stmt\Expression;`
`7`	`7`	`use PHPStan\Analyser\Scope;`
`8`	`8`	`use PHPStan\Collectors\Collector;`
`9`	`9`	`use PHPStan\Reflection\ReflectionProvider;`
`10`	`10`
`11`	`11`	`/**`
`12`		`- * @implements Collector<FuncCall, array{string, int}>`
	`12`	`+ * @implements Collector<Node\Stmt\Expression, array{string, int}>`
`13`	`13`	`*/`
`14`	`14`	`class PossiblyPureFuncCallCollector implements Collector`
`15`	`15`	`{`
`@@ -20,20 +20,23 @@ public function __construct(private ReflectionProvider $reflectionProvider)`
`20`	`20`
`21`	`21`	`public function getNodeType(): string`
`22`	`22`	`{`
`23`		`- return FuncCall::class;`
	`23`	`+ return Expression::class;`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public function processNode(Node $node, Scope $scope)`
`27`	`27`	`{`
`28`		`- if (!$node->name instanceof Node\Name) {`
	`28`	`+ if (!$node->expr instanceof Node\Expr\FuncCall) {`
	`29`	`+ return null;`
	`30`	`+ }`
	`31`	`+ if (!$node->expr->name instanceof Node\Name) {`
`29`	`32`	`return null;`
`30`	`33`	`}`
`31`	`34`
`32`		`- if (!$this->reflectionProvider->hasFunction($node->name, $scope)) {`
	`35`	`+ if (!$this->reflectionProvider->hasFunction($node->expr->name, $scope)) {`
`33`	`36`	`return null;`
`34`	`37`	`}`
`35`	`38`
`36`		`- $functionReflection = $this->reflectionProvider->getFunction($node->name, $scope);`
	`39`	`+ $functionReflection = $this->reflectionProvider->getFunction($node->expr->name, $scope);`
`37`	`40`	`if (!$functionReflection->isPure()->maybe()) {`
`38`	`41`	`return null;`
`39`	`42`	`}`