TypeSpecifier - understand preg_match() === 1 same way as preg_match()

ondrejmirtes · ondrejmirtes · commit 328fcb91de16 · 2024-06-21T11:34:50.000+02:00
diff --git a/src/Analyser/TypeSpecifier.php b/src/Analyser/TypeSpecifier.php
@@ -1989,6 +1989,22 @@ public function resolveIdentical(Expr\BinaryOp\Identical $expr, Scope $scope, Ty
 			$unwrappedRightExpr = $rightExpr->getExpr();
 		}
 		$rightType = $scope->getType($rightExpr);
+
+		if (
+			$context->true()
+			&& $unwrappedLeftExpr instanceof FuncCall
+			&& $unwrappedLeftExpr->name instanceof Name
+			&& $unwrappedLeftExpr->name->toLowerString() === 'preg_match'
+			&& (new ConstantIntegerType(1))->isSuperTypeOf($rightType)->yes()
+		) {
+			return $this->specifyTypesInCondition(
+				$scope,
+				$leftExpr,
+				$context,
+				$rootExpr,
+			);
+		}
+
 		if (
 			$context->true()
 			&& $unwrappedLeftExpr instanceof FuncCall
diff --git a/tests/PHPStan/Analyser/nsrt/preg_match_shapes_php74.php b/tests/PHPStan/Analyser/nsrt/preg_match_shapes_php74.php
@@ -164,3 +164,34 @@ function testHoaUnsupportedRegexSyntax(string $s): void {
 	}
 	assertType('array{}|array{string}', $matches);
 }
+
+function testPregMatchSimpleCondition(string $value): void {
+	if (preg_match('/%env\((.*)\:.*\)%/U', $value, $matches)) {
+		assertType('array{string, string}', $matches);
+	}
+}
+
+
+function testPregMatchIdenticalToOne(string $value): void {
+	if (preg_match('/%env\((.*)\:.*\)%/U', $value, $matches) === 1) {
+		assertType('array{string, string}', $matches);
+	}
+}
+
+function testPregMatchIdenticalToOneFalseyContext(string $value): void {
+	if (!(preg_match('/%env\((.*)\:.*\)%/U', $value, $matches) !== 1)) {
+		assertType('array{string, string}', $matches);
+	}
+}
+
+function testPregMatchIdenticalToOneInverted(string $value): void {
+	if (1 === preg_match('/%env\((.*)\:.*\)%/U', $value, $matches)) {
+		assertType('array{string, string}', $matches);
+	}
+}
+
+function testPregMatchIdenticalToOneFalseyContextInverted(string $value): void {
+	if (!(1 !== preg_match('/%env\((.*)\:.*\)%/U', $value, $matches))) {
+		assertType('array{string, string}', $matches);
+	}
+}
