Fix empty array as type in VarTagTypeRuleHelper

ondrejmirtes · ondrejmirtes · commit 256e8dcfb629 · 2023-11-17T09:56:04.000+01:00
diff --git a/src/Rules/PhpDoc/VarTagTypeRuleHelper.php b/src/Rules/PhpDoc/VarTagTypeRuleHelper.php
@@ -156,6 +156,13 @@ private function shouldVarTagTypeBeReported(Node\Expr $expr, Type $type, Type $v
 
 	private function checkType(Type $type, Type $varTagType): bool
 	{
+		if ($type->isConstantArray()->yes()) {
+			if ($type->isIterableAtLeastOnce()->no()) {
+				$type = new ArrayType(new MixedType(), new MixedType());
+				return $type->isSuperTypeOf($varTagType)->no();
+			}
+		}
+
 		if ($type->isIterable()->yes() && $varTagType->isIterable()->yes()) {
 			if ($type->isSuperTypeOf($varTagType)->no()) {
 				return true;
diff --git a/tests/PHPStan/Rules/PhpDoc/data/var-above-empty-array-widening.php b/tests/PHPStan/Rules/PhpDoc/data/var-above-empty-array-widening.php
@@ -22,3 +22,8 @@
 
 /** @var int $a */
 $a = [];
+
+$translationsTree = [];
+
+/** @var array $byRef */
+$byRef = &$translationsTree;
