Add collision-detector.json to export-ignore in .gitattributes#746
Merged
Conversation
VincentLanglet
approved these changes
May 7, 2026
staabm
approved these changes
May 8, 2026
Contributor
|
Thank you |
raphaelstolt
reviewed
May 8, 2026
| phpunit.xml export-ignore | ||
| stubs/runtime/Enum/UnitEnum.php export-ignore | ||
| stubs/runtime/Enum/BackedEnum.php export-ignore | ||
| /collision-detector.json export-ignore |
There was a problem hiding this comment.
There's no need to prefix files with a /. Even for directories e.g. tests a test/ export-ignore is suffice.
Contributor
There was a problem hiding this comment.
Please send a PR in case you want to improve things
There was a problem hiding this comment.
That was more a comment for @sasezaki for his eventually forthcoming .gitattributes related PRs. He's currently opening a lot of them.
No need on my end to open a PR for one unnecessary character.
✌️
Contributor
Author
There was a problem hiding this comment.
Thank you for the advice.
In the case of this Pull Request, it would have been better to omit the '/' from the perspective of consistency with the existing export-ignore line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current archive targets other than src/ will be as follows:
With this PR, the archive targets other than src/ will be as follows:
Changes:
collision-detector.json export-ignorecollision-detector.json: A configuration file for the collision-detector dev tool; not needed by package consumers.