Feature request
In Psalm, @psalm-readonly-allow-private-mutation is shorthand for combining @readonly and @psalm-allow-private-mutation. Adding @psalm-readonly-allow-private-mutation to PHPStan as an alias for @readonly improves interoperability.
I liked Psalm's @psalm-allow-private-mutation so I looked into PHPStan's implementation to bring the same functionality into PHPStan, but found that ReadOnlyByPhpDocPropertyAssignRule implicitly behaves as a private mutation. So we don't need to add @phpstan-allow-private-mutation.
Did PHPStan help you today? Did it make you happy in any way?
I've been working on a major refactoring for the last few days and I'm really grateful for PHPStan.
Feature request
In Psalm,
@psalm-readonly-allow-private-mutationis shorthand for combining@readonlyand@psalm-allow-private-mutation. Adding@psalm-readonly-allow-private-mutationto PHPStan as an alias for@readonlyimproves interoperability.I liked Psalm's
@psalm-allow-private-mutationso I looked into PHPStan's implementation to bring the same functionality into PHPStan, but found thatReadOnlyByPhpDocPropertyAssignRuleimplicitly behaves as a private mutation. So we don't need to add@phpstan-allow-private-mutation.Did PHPStan help you today? Did it make you happy in any way?
I've been working on a major refactoring for the last few days and I'm really grateful for PHPStan.