Skip to content

Do not suggest to turn off treatPhpDocTypesAsCertain when it's enabled explicitly #11689

@ruudk

Description

@ruudk

Feature request

We have configured it explicitly like this: treatPhpDocTypesAsCertain: true.

But PHPstan always hints that we should turn it off. We don't want to turn it off, we want to keep it on.

While looking at the implementation I can see why it's done like this. The tip is added on the RuleErrorBuilder and it's unaware of the configuration / parameters.

Could we somehow change this, so that when treatPhpDocTypesAsCertain is undefined (null), it shows the tips.
But when it's explicitly enabled or disabled, it does not?

Did PHPStan help you today? Did it make you happy in any way?

💙

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions