Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preg_match greater than 0 #11293

Closed
ondrejmirtes opened this issue Jul 6, 2024 · 10 comments
Closed

preg_match greater than 0 #11293

ondrejmirtes opened this issue Jul 6, 2024 · 10 comments
Labels
bug
Milestone
Easy fixes

Comments

@ondrejmirtes
Copy link
Member

Bug report

All of these conditions should be understood the same way

/cc @staabm

Code snippet that reproduces the problem

https://phpstan.org/r/774080cc-2f73-49a5-a049-491d030ca831

Expected output

Same dumped type in all cases

Did PHPStan help you today? Did it make you happy in any way?

No response
@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Jul 6, 2024
@phpstan-bot
Copy link
Contributor

@ondrejmirtes After the latest push in 1.12.x, PHPStan now reports different result with your code snippet:

@@ @@
- 8: Dumped type: array{0?: string, 1?: string}
-15: Dumped type: array{string, string}
-22: Dumped type: array{0?: string, 1?: string}
-32: Dumped type: array{0?: string, 1?: string}
-41: Dumped type: array{0?: string, 1?: string}
+ 8: Dumped type: array<string>
+15: Dumped type: array<string>
+22: Dumped type: array<string>
+32: Dumped type: array<string>
+41: Dumped type: array<string>
Full report
Line Error
8 Dumped type: array<string>
15 Dumped type: array<string>
22 Dumped type: array<string>
32 Dumped type: array<string>
41 Dumped type: array<string>

@staabm staabm mentioned this issue Jul 11, 2024
Merged
@phpstan phpstan deleted a comment from phpstan-bot Jul 19, 2024
@phpstan phpstan deleted a comment from phpstan-bot Jul 19, 2024
@phpstan-bot
Copy link
Contributor

@ondrejmirtes After the latest push in 1.12.x, PHPStan now reports different result with your code snippet:

@@ @@
- 8: Dumped type: array{0?: string, 1?: string}
-15: Dumped type: array{string, string}
-22: Dumped type: array{0?: string, 1?: string}
-32: Dumped type: array{0?: string, 1?: string}
-41: Dumped type: array{0?: string, 1?: string}
+ 8: Dumped type: array{0?: string, 1?: numeric-string}
+15: Dumped type: array{string, numeric-string}
+22: Dumped type: array{0?: string, 1?: numeric-string}
+32: Dumped type: array{0?: string, 1?: numeric-string}
+41: Dumped type: array{0?: string, 1?: numeric-string}
Full report
Line Error
8 Dumped type: array{0?: string, 1?: numeric-string}
15 Dumped type: array{string, numeric-string}
22 Dumped type: array{0?: string, 1?: numeric-string}
32 Dumped type: array{0?: string, 1?: numeric-string}
41 Dumped type: array{0?: string, 1?: numeric-string}

@phpstan-bot
Copy link
Contributor

@ondrejmirtes After the latest push in 1.12.x, PHPStan now reports different result with your code snippet:

@@ @@
- 8: Dumped type: array{0?: string, 1?: string}
-15: Dumped type: array{string, string}
-22: Dumped type: array{0?: string, 1?: string}
-32: Dumped type: array{0?: string, 1?: string}
-41: Dumped type: array{0?: string, 1?: string}
+ 8: Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}
+15: Dumped type: array{string, non-falsy-string&numeric-string}
+22: Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}
+32: Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}
+41: Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}
Full report
Line Error
8 Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}
15 Dumped type: array{string, non-falsy-string&numeric-string}
22 Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}
32 Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}
41 Dumped type: array{0?: string, 1?: non-falsy-string&numeric-string}

@staabm staabm mentioned this issue Aug 29, 2024
Closed
@dktapps
Copy link
Contributor

dktapps commented Sep 3, 2024

Yep, ran into this problem in a bunch of places in PocketMine: https://github.com/pmmp/PocketMine-MP/actions/runs/10665106327/job/29557785290?pr=6441

@dktapps dktapps mentioned this issue Sep 3, 2024
Closed
@staabm
Copy link
Contributor

staabm commented Sep 3, 2024 •
edited
Loading

another example combining int-cast and smaller-then (copied from #11262)

https://phpstan.org/r/0d011355-4446-4bd8-9b8d-0c44907f9a07

@staabm staabm mentioned this issue Sep 3, 2024
Closed
@phpstan-bot
Copy link
Contributor

@staabm After the latest push in 1.12.x, PHPStan now reports different result with your code snippet:

@@ @@
-17: Offset 'background_image' might not exist on array{0?: string, background_image?: string, 1?: string}.
+17: Offset 'background_image' might not exist on array{0?: string, background_image?: non-empty-string, 1?: non-empty-string}.
Full report
Line Error
17 Offset 'background_image' might not exist on array{0?: string, background_image?: non-empty-string, 1?: non-empty-string}.

@tscni tscni mentioned this issue Sep 7, 2024
Closed
@dktapps dktapps mentioned this issue Sep 19, 2024
Closed
@nicholasruunu
Copy link

Does this have to do with the issue I'm having?
https://phpstan.org/r/4f406a70-f5f5-42ab-84ab-19c6c8f6549a

@ondrejmirtes
Copy link
Member Author

@nicholasruunu Unrelated, please open a separate discussion.

@tlamy tlamy mentioned this issue Oct 17, 2024
Closed
@staabm staabm mentioned this issue Nov 8, 2024
Merged
@ondrejmirtes
Copy link
Member Author

Fixed phpstan/phpstan-src#3612

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Easy fixes
Development

No branches or pull requests
5 participants
@ondrejmirtes @staabm @nicholasruunu @dktapps @phpstan-bot