Replies: 2 comments 8 replies
-
|
Try to play with explicit mixed ( |
Beta Was this translation helpful? Give feedback.
-
|
weird, I cannot make the linked snippet fail in a test, not even in an AnalyserIntegrationTest. It doesn't even report that one error from the playground. If I add other invalid code it errors though. any quick ideas? I tried already re-generating the autoloader and moving the code inside a class. I must be overlooking something simple again.. |
Beta Was this translation helpful? Give feedback.
-
|
FOUND IT. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, one more: https://phpstan.org/r/20dbafcb-e98c-48f8-adc6-e32a2bc15acd should unsafe offset access on normal arrays be reported too? Or is this on purpose? All of those would lead to warnings and null values. |
Beta Was this translation helpful? Give feedback.
-
|
There's some extra code to make sure this IS NOT reported: https://github.com/phpstan/phpstan-src/blob/beac2678a8d29484fb7a914197599d689850b7eb/src/Rules/Arrays/NonexistentOffsetInArrayDimFetchChi A few notes:
|
Beta Was this translation helpful? Give feedback.
-
|
thx for the pointers. Not sure if this makes sense or is too much. Sounds like the latter if you don't want to even have it in strict-rules :) |
Beta Was this translation helpful? Give feedback.
-
|
Nope, definitely not, stdClass will never report that property as undefined 😊 |
Beta Was this translation helpful? Give feedback.
-
|
just to clarify - you mean it will/should never report in phpstan, right? I'm really not using it often, but in general it seems to be creating notices in PHP at least. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Is it on purpose that superglobal offset access is not handled strictly? I assume the reason is that implicit
mixedis created here or smth like that?E.g. https://phpstan.org/r/924c008a-eb32-4442-98a3-14545bbd8f83
I was expecting that PHPStan also strictly checks the
$_POSToffset and then later the usage of the$argsarray. Any suggestions in how to work with that? I try to explain to colleagues that we should handle this type-safe but we seem to be doing this kind of in the dark since PHPStan is not checking it.Or am I missing something obvious (config?) here?
Beta Was this translation helpful? Give feedback.
All reactions