Replies: 1 comment 3 replies
-
|
I'd like to remove this cache altogether because the files are parsed anyway. The idea is to have a node visitor that writes which functions are variadic into the attribute of the top-most Node in each file AST. This node visitor would be registered for both rich parser and simple parser. |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I have a local project in which blackfire reports the slowest part (7% of everything) as
Cache/FileCacheStorage.phpwhich get invoked mostly viaPhpMethodReflection->getVariants():the 2 most callers of
PhpMethodReflection->getVariants()are1st
2nd
I was looking at the sources for a few hours and did not yet have an idea whether this could be made more efficient.
maybe others have a idea, therefore I thought I will leave it here.
Tested on PHPStan 1.12.4 windows11:
Beta Was this translation helpful? Give feedback.
All reactions