Regression test

ondrejmirtes · ondrejmirtes · commit 93f509e3fa29 · 2021-06-16T21:20:52.000+02:00
Closes #3151
diff --git a/tests/PHPStan/Rules/Methods/ReturnTypeRuleTest.php b/tests/PHPStan/Rules/Methods/ReturnTypeRuleTest.php
@@ -507,4 +507,9 @@ public function testBug4603(): void
 		$this->analyse([__DIR__ . '/data/bug-4603.php'], []);
 	}
 
+	public function testBug3151(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-3151.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/bug-3151.php b/tests/PHPStan/Rules/Methods/data/bug-3151.php
@@ -0,0 +1,39 @@
+<?php
+
+namespace Bug3151;
+
+class Foo
+{
+
+	/**
+	 * @template T
+	 * @param T[] $haystack
+	 * @param callable(T): bool $matcher
+	 * @return T|null;
+	 */
+	function search(array $haystack, callable $matcher)
+	{
+		foreach ($haystack as $item) {
+			if (!$matcher($item)) {
+				continue;
+			}
+			return $item;
+		}
+		return null;
+	}
+
+	/**
+	 * @param array<array{type: string, foo: string}> $myArray
+	 * @return array{type: string, foo: string}
+	 */
+	function findByType(array $myArray, string $type): array {
+		$found = $this->search($myArray, function(array $item) use ($type): bool {
+			return $item['type'] === $type;
+		});
+		if ($found === null) {
+			throw new \LogicException();
+		}
+		return $found;
+	}
+
+}

Original file line number	Diff line number	Diff line change
`@@ -507,4 +507,9 @@ public function testBug4603(): void`
`507`	`507`	`$this->analyse([__DIR__ . '/data/bug-4603.php'], []);`
`508`	`508`	`}`
`509`	`509`
	`510`	`+ public function testBug3151(): void`
	`511`	`+ {`
	`512`	`+ $this->analyse([__DIR__ . '/data/bug-3151.php'], []);`
	`513`	`+ }`
	`514`	`+`
`510`	`515`	`}`