-
-
Notifications
You must be signed in to change notification settings - Fork 685
"Last online" stuck on "never" when checking some websites #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Last online" stuck on "never" when checking some websites #770
Conversation
// The update un "servers" table does not work // Symptom : "Last online" stays stuck on "never" // Reason: last_output contains the full webpage, too long for the query // _This may depend on mysql configuration on the server_, explaining why some have the problem or not // Field is 255 Chars, and request does not work anyway is loaded web page is too large in last_output // So force truncate to 250 or less before query
|
Mysql error message : |
|
I think I prefer #765 over restricting the last_output to 255 characters. What do you think? |
|
Ok I thought the 255 char length was a choice you made Well but in the end, do we really need more that 255 chars ? |
|
No it wasn't it really a well thought out choice. |
|
I agree, if it's for monitoring, no use to keep a load of data. I think in most cases, in case of problem the page result would be quite short |
|
Okay I tested it and 255 is not enough. 16mb on the other hand is too much. Limiting it to 5000 char is plenty I think. 🤔 Like a basic Google header is around 1000 char. |
Fixes #765 * // PATCH Arkhee : fix/last-online-stuck-on-never-if-webpage-too-large // The update un "servers" table does not work // Symptom : "Last online" stays stuck on "never" // Reason: last_output contains the full webpage, too long for the query // _This may depend on mysql configuration on the server_, explaining why some have the problem or not // Field is 255 Chars, and request does not work anyway is loaded web page is too large in last_output // So force truncate to 250 or less before query * Spelling * Update varchar to text * Update tot 3.4.1 * Update tot 3.4.1 * Update README.rst * Updated to 5000 characters
Fixes #765 * // PATCH Arkhee : fix/last-online-stuck-on-never-if-webpage-too-large // The update un "servers" table does not work // Symptom : "Last online" stays stuck on "never" // Reason: last_output contains the full webpage, too long for the query // _This may depend on mysql configuration on the server_, explaining why some have the problem or not // Field is 255 Chars, and request does not work anyway is loaded web page is too large in last_output // So force truncate to 250 or less before query * Spelling * Update varchar to text * Update tot 3.4.1 * Update tot 3.4.1 * Update README.rst * Updated to 5000 characters
Added the first part with #770. Forgot to add it to the fresh install function. Also removed the default value for TEXT as TEXT can't have a default value. Co-Authored-By: Matěj Kmínek <[email protected]>
Some users (included me) noticed some kind of random behavior when checking web page : ususally the server status would not update
This is probably due to mysql server configuration regarding the size of the data which is inserted in a text field : server monitor stores the full loaded webpage, sometimes the query field is too big, even when setting "last_output" to "text" instead of "varchar", the error may depend on a mysql setting.
So since the field is varchar 255, the solution is juste to truncate the data to 255 or lower before save