Issue #734 #741
Merged
Issue #734 #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Full disclosure... this is my first time with Twig, so there's probably a better solution (this one is fully functional though). |
TimZ99
requested changes
Jul 17, 2019
and changed 'see complete' to 'show more'.
TimZ99
approved these changes
Sep 17, 2019
TimZ99
pushed a commit
that referenced
this pull request
Sep 17, 2019
* Truncate outputs * Add modals to show the complete output * Add 'See complete...' buttons * Improve "See Complete..." button * Use nl2br filter * Use button instead of <a> looks much better * Removed font-family: Mono and changed 'see complete' to 'show more'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix #734, this PR truncates the outputs if necessary, then show a
See complete...button and show the outputs on a modal: