Skip to content

Conversation

@petrk94
Copy link
Contributor

@petrk94 petrk94 commented Aug 15, 2018

This script was made by me, as I got the problem how to update it.
As @TimZ99 helped me how to update #619 , I thought about why not make a update mechanism.
So I wrote this shell script, which identify the latest available version via github API with cURL, download it with wget as update.zip and extract it with unzip.
Afterwards there will some files moved and it tell you that the update was successfully.

Its a script made in a hour, nothing complicated with if etc. so I want to provide this pull request already now and update the script with some more logic like, ready for update? (yes/no), exist vendor directory (for php composer.phar install)

Please check the script, I were glad if you accept my pull request.
Thanks

@petrk94
Copy link
Contributor Author

petrk94 commented Aug 18, 2018

@TimZ99 takes that really such long to get the pull request approved?^^

@TimZ99
Copy link
Member

TimZ99 commented Aug 18, 2018

I had some issues testing the script and ran out of time, so I decided to review at a later time.

@petrk94
Copy link
Contributor Author

petrk94 commented Aug 18, 2018

@TimZ99 can you tell me what issues you had? Than I can try to reproduce it. The updater script is even not yet perfect, there are still some logic missing to decide whether user is ready for update etc.
I can even write a debug function, if it helps.

@TimZ99
Copy link
Member

TimZ99 commented Aug 18, 2018

It was a wrong file permission.
And wget wasn't installed.

Remove vendor directory.
Moved removing files until after checking if wget is installed.
@petrk94
Copy link
Contributor Author

petrk94 commented Aug 18, 2018

@TimZ99 well, you are the first who I notice who has not wget installed on a linux machine by default^^ thanks for updating the if logic for that.
I thought more about to integrate a if logic function, to check whether vendor exist, before running not necessary composer.phar.

@TimZ99
Copy link
Member

TimZ99 commented Aug 18, 2018

Haha I'm running macOS on this machine. It's missing some parts like wget.

The vendor folder can stay, but the composer command needs to be set to update then.

@petrk94
Copy link
Contributor Author

petrk94 commented Aug 18, 2018

ah I see^^
Well than this is explaining it. I could not develop on MacOS. Im writing code on my Windows machine and upload it to run on my linux server.

@petrk94
Copy link
Contributor Author

petrk94 commented Aug 19, 2018

yes, thats how I imagined it^^
Is it ready now for work?

@TimZ99 TimZ99 self-requested a review August 28, 2018 11:47
@petrk94
Copy link
Contributor Author

petrk94 commented Sep 17, 2018

Any update here?

@TimZ99
Copy link
Member

TimZ99 commented Sep 17, 2018

I really don't know why I haven't merged this already.

@TimZ99
Copy link
Member

TimZ99 commented Sep 17, 2018

That's why ^^^

@TimZ99 TimZ99 merged commit 63a2a6b into phpservermon:develop Sep 17, 2018
@petrk94
Copy link
Contributor Author

petrk94 commented Sep 17, 2018

thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants