-
-
Notifications
You must be signed in to change notification settings - Fork 685
added updater.sh shell script #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@TimZ99 takes that really such long to get the pull request approved?^^ |
|
I had some issues testing the script and ran out of time, so I decided to review at a later time. |
|
@TimZ99 can you tell me what issues you had? Than I can try to reproduce it. The updater script is even not yet perfect, there are still some logic missing to decide whether user is ready for update etc. |
|
It was a wrong file permission. |
Remove vendor directory. Moved removing files until after checking if wget is installed.
|
@TimZ99 well, you are the first who I notice who has not wget installed on a linux machine by default^^ thanks for updating the if logic for that. |
|
Haha I'm running macOS on this machine. It's missing some parts like wget. The vendor folder can stay, but the composer command needs to be set to update then. |
|
ah I see^^ |
|
yes, thats how I imagined it^^ |
|
Any update here? |
|
I really don't know why I haven't merged this already. |
|
That's why ^^^ |
|
thanks for merging :) |
This script was made by me, as I got the problem how to update it.
As @TimZ99 helped me how to update #619 , I thought about why not make a update mechanism.
So I wrote this shell script, which identify the latest available version via github API with cURL, download it with wget as update.zip and extract it with unzip.
Afterwards there will some files moved and it tell you that the update was successfully.
Its a script made in a hour, nothing complicated with if etc. so I want to provide this pull request already now and update the script with some more logic like, ready for update? (yes/no), exist vendor directory (for php composer.phar install)
Please check the script, I were glad if you accept my pull request.
Thanks