Skip to content

Commit 9226b62

Browse files
MauricioFauthMauricioFauth
committed
Update Psalm baseline
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
1 parent de90c28 commit 9226b62

File tree

1 file changed

+141
-2
lines changed

1 file changed

+141
-2
lines changed

‎psalm-baseline.xml‎

Lines changed: 141 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<files psalm-version="5.19.0@06b71be009a6bd6d81b9811855d6629b9fe90e1b">
2+
<files psalm-version="5.20.0@3f284e96c9d9be6fe6b15c79416e1d1903dcfef4">
33
<file src="src/Components/AlterOperation.php">
44
<PossiblyNullPropertyAssignmentValue>
55
<code>$options</code>
@@ -15,6 +15,9 @@
1515
<code>$partitionState === 2</code>
1616
<code>$state === 3</code>
1717
</RedundantCondition>
18+
<RiskyTruthyFalsyComparison>
19+
<code><![CDATA[empty($ret->field)]]></code>
20+
</RiskyTruthyFalsyComparison>
1821
</file>
1922
<file src="src/Components/Array2d.php">
2023
<RedundantCondition>
@@ -51,6 +54,9 @@
5154
<code><![CDATA[$ret->values]]></code>
5255
<code><![CDATA[$ret->values]]></code>
5356
</PossiblyInvalidPropertyFetch>
57+
<RiskyTruthyFalsyComparison>
58+
<code><![CDATA[empty($options['typeOptions'])]]></code>
59+
</RiskyTruthyFalsyComparison>
5460
<UndefinedMethod>
5561
<code>$ret</code>
5662
</UndefinedMethod>
@@ -70,6 +76,12 @@
7076
<MixedOperand>
7177
<code><![CDATA[$token->value]]></code>
7278
</MixedOperand>
79+
<RiskyTruthyFalsyComparison>
80+
<code><![CDATA[! $token->flags & Token::FLAG_SYMBOL_VARIABLE]]></code>
81+
<code><![CDATA[$this->alias]]></code>
82+
<code><![CDATA[empty($ret->alias)]]></code>
83+
<code><![CDATA[empty($ret->alias)]]></code>
84+
</RiskyTruthyFalsyComparison>
7385
</file>
7486
<file src="src/Components/Condition.php">
7587
<MixedArrayOffset>
@@ -78,6 +90,9 @@
7890
<PossiblyUnusedProperty>
7991
<code>$isOperator</code>
8092
</PossiblyUnusedProperty>
93+
<TypeDoesNotContainType>
94+
<code><![CDATA[empty(self::ALLOWED_KEYWORDS[$token->value])]]></code>
95+
</TypeDoesNotContainType>
8196
</file>
8297
<file src="src/Components/CreateDefinition.php">
8398
<MixedAssignment>
@@ -125,8 +140,17 @@
125140
<code><![CDATA[$ret->expr]]></code>
126141
<code><![CDATA[$ret->expr]]></code>
127142
</PossiblyNullOperand>
143+
<RiskyTruthyFalsyComparison>
144+
<code><![CDATA[empty($ret->alias)]]></code>
145+
<code><![CDATA[empty($ret->alias)]]></code>
146+
<code><![CDATA[empty($ret->alias)]]></code>
147+
<code><![CDATA[empty($ret->database)]]></code>
148+
<code><![CDATA[empty($ret->subquery)]]></code>
149+
<code><![CDATA[empty($this->alias)]]></code>
150+
</RiskyTruthyFalsyComparison>
128151
<TypeDoesNotContainType>
129152
<code><![CDATA[$brackets < 0]]></code>
153+
<code><![CDATA[empty(self::ALLOWED_KEYWORDS[$token->keyword])]]></code>
130154
</TypeDoesNotContainType>
131155
</file>
132156
<file src="src/Components/ExpressionArray.php">
@@ -171,6 +195,10 @@
171195
<RedundantCondition>
172196
<code>$state === 1</code>
173197
</RedundantCondition>
198+
<RedundantConditionGivenDocblockType>
199+
<code><![CDATA[! empty($expr->expr)]]></code>
200+
<code><![CDATA[! empty($expr->expr)]]></code>
201+
</RedundantConditionGivenDocblockType>
174202
</file>
175203
<file src="src/Components/IndexHint.php">
176204
<MixedAssignment>
@@ -195,6 +223,9 @@
195223
<PossiblyNullOperand>
196224
<code><![CDATA[$this->dest]]></code>
197225
</PossiblyNullOperand>
226+
<RiskyTruthyFalsyComparison>
227+
<code><![CDATA[empty($this->columns)]]></code>
228+
</RiskyTruthyFalsyComparison>
198229
</file>
199230
<file src="src/Components/JoinKeyword.php">
200231
<DocblockTypeContradiction>
@@ -220,6 +251,13 @@
220251
<RedundantCondition>
221252
<code>$state === 4</code>
222253
</RedundantCondition>
254+
<RedundantConditionGivenDocblockType>
255+
<code><![CDATA[! empty($c->using)]]></code>
256+
</RedundantConditionGivenDocblockType>
257+
<TypeDoesNotContainType>
258+
<code><![CDATA[empty(self::JOINS[$token->keyword])]]></code>
259+
<code><![CDATA[empty(self::JOINS[$token->keyword])]]></code>
260+
</TypeDoesNotContainType>
223261
</file>
224262
<file src="src/Components/Key.php">
225263
<MixedAssignment>
@@ -341,6 +379,10 @@
341379
<PossiblyNullPropertyFetch>
342380
<code><![CDATA[$ret->options[$lastOptionId]['expr']->expr]]></code>
343381
</PossiblyNullPropertyFetch>
382+
<RiskyTruthyFalsyComparison>
383+
<code>$lastOption</code>
384+
<code>empty($lastOption[2])</code>
385+
</RiskyTruthyFalsyComparison>
344386
</file>
345387
<file src="src/Components/OrderKeyword.php">
346388
<PossiblyNullPropertyAssignmentValue>
@@ -350,6 +392,10 @@
350392
<RedundantCondition>
351393
<code>$state === 1</code>
352394
</RedundantCondition>
395+
<RedundantConditionGivenDocblockType>
396+
<code><![CDATA[! empty($expr->expr)]]></code>
397+
<code><![CDATA[! empty($expr->expr)]]></code>
398+
</RedundantConditionGivenDocblockType>
353399
</file>
354400
<file src="src/Components/ParameterDefinition.php">
355401
<MixedAssignment>
@@ -404,6 +450,9 @@
404450
<RedundantCondition>
405451
<code>$state === 6</code>
406452
</RedundantCondition>
453+
<RedundantConditionGivenDocblockType>
454+
<code><![CDATA[! empty($this->options)]]></code>
455+
</RedundantConditionGivenDocblockType>
407456
<UnusedVariable>
408457
<code>$idx</code>
409458
</UnusedVariable>
@@ -452,6 +501,9 @@
452501
<RedundantCondition>
453502
<code>$state === 3</code>
454503
</RedundantCondition>
504+
<RedundantConditionGivenDocblockType>
505+
<code><![CDATA[! empty($expr->old)]]></code>
506+
</RedundantConditionGivenDocblockType>
455507
</file>
456508
<file src="src/Components/SetOperation.php">
457509
<PossiblyNullPropertyAssignmentValue>
@@ -472,6 +524,10 @@
472524
<MixedAssignment>
473525
<code>self::$keywords</code>
474526
</MixedAssignment>
527+
<RiskyTruthyFalsyComparison>
528+
<code>empty($flag)</code>
529+
<code>static::isKeyword($str, true)</code>
530+
</RiskyTruthyFalsyComparison>
475531
</file>
476532
<file src="src/Contexts/ContextMariaDb100000.php">
477533
<UnusedClass>
@@ -638,6 +694,16 @@
638694
<code><![CDATA[$next->value]]></code>
639695
<code><![CDATA[$next->value]]></code>
640696
</PossiblyNullPropertyFetch>
697+
<RiskyTruthyFalsyComparison>
698+
<code>! $flags</code>
699+
<code>! $flags</code>
700+
<code>! $flags</code>
701+
<code>! $flags</code>
702+
<code>Context::isComment($token)</code>
703+
<code>Context::isComment($token)</code>
704+
<code>Context::isComment($token, $end)</code>
705+
<code>empty($delimiter)</code>
706+
</RiskyTruthyFalsyComparison>
641707
</file>
642708
<file src="src/Parser.php">
643709
<InvalidPropertyAssignmentValue>
@@ -702,8 +768,11 @@
702768
</UnsupportedPropertyReferenceUsage>
703769
</file>
704770
<file src="src/Statement.php">
771+
<DocblockTypeContradiction>
772+
<code><![CDATA[empty(static::$clauses[$token->value])]]></code>
773+
<code><![CDATA[empty(static::$statementOptions[$token->value])]]></code>
774+
</DocblockTypeContradiction>
705775
<InvalidArgument>
706-
<code>$built[$field]</code>
707776
<code><![CDATA[$parsedClauses[$token->value]]]></code>
708777
</InvalidArgument>
709778
<MixedArgument>
@@ -747,6 +816,15 @@
747816
<PossiblyUnusedReturnValue>
748817
<code>bool</code>
749818
</PossiblyUnusedReturnValue>
819+
<RedundantCondition>
820+
<code><![CDATA[! empty($parsedClauses[$token->value])]]></code>
821+
</RedundantCondition>
822+
<RiskyTruthyFalsyComparison>
823+
<code><![CDATA[! stripos($clauseType, 'JOIN')]]></code>
824+
<code><![CDATA[empty(Parser::KEYWORD_PARSERS[$tokenValue]['options'])]]></code>
825+
<code><![CDATA[stripos($clauseType, 'JOIN')]]></code>
826+
<code><![CDATA[stripos($clauseType, 'JOIN')]]></code>
827+
</RiskyTruthyFalsyComparison>
750828
<UndefinedMethod>
751829
<code><![CDATA[$class::buildAll($this->$field)]]></code>
752830
<code><![CDATA[$class::buildAll($this->$field)]]></code>
@@ -843,6 +921,14 @@
843921
)]]></code>
844922
<code>ArrayObj::parse($parser, $list)</code>
845923
</PropertyTypeCoercion>
924+
<RiskyTruthyFalsyComparison>
925+
<code><![CDATA[empty($this->partitionBy)]]></code>
926+
<code><![CDATA[empty($this->partitionBy)]]></code>
927+
<code><![CDATA[empty($this->partitions)]]></code>
928+
<code><![CDATA[empty($this->partitionsNum)]]></code>
929+
<code><![CDATA[empty($this->subpartitionBy)]]></code>
930+
<code><![CDATA[empty($this->subpartitionsNum)]]></code>
931+
</RiskyTruthyFalsyComparison>
846932
</file>
847933
<file src="src/Statements/DeleteStatement.php">
848934
<MixedArgument>
@@ -891,6 +977,9 @@
891977
<RedundantCondition>
892978
<code>$state === 3</code>
893979
</RedundantCondition>
980+
<RiskyTruthyFalsyComparison>
981+
<code><![CDATA[$this->connectionId]]></code>
982+
</RiskyTruthyFalsyComparison>
894983
</file>
895984
<file src="src/Statements/InsertStatement.php">
896985
<PossiblyNullOperand>
@@ -979,6 +1068,9 @@
9791068
<code>$indexHints</code>
9801069
<code>$partition</code>
9811070
</PossiblyUnusedProperty>
1071+
<RiskyTruthyFalsyComparison>
1072+
<code><![CDATA[empty($this->join)]]></code>
1073+
</RiskyTruthyFalsyComparison>
9821074
</file>
9831075
<file src="src/Statements/SetStatement.php">
9841076
<PossiblyNullArgument>
@@ -1065,6 +1157,11 @@
10651157
<code>$debugFile</code>
10661158
<code>$debugFile</code>
10671159
</PossiblyNullArgument>
1160+
<RiskyTruthyFalsyComparison>
1161+
<code>empty($debug)</code>
1162+
<code><![CDATA[empty($parser->errors)]]></code>
1163+
<code>empty($query)</code>
1164+
</RiskyTruthyFalsyComparison>
10681165
</file>
10691166
<file src="src/Translator.php">
10701167
<RedundantPropertyInitializationCheck>
@@ -1193,6 +1290,14 @@
11931290
<code><![CDATA[$params['q']]]></code>
11941291
<code><![CDATA[$params['q']]]></code>
11951292
</PossiblyFalseArgument>
1293+
<PossiblyUnusedMethod>
1294+
<code>run</code>
1295+
</PossiblyUnusedMethod>
1296+
<RiskyTruthyFalsyComparison>
1297+
<code>$stdIn</code>
1298+
<code>$stdIn</code>
1299+
<code>$stdIn</code>
1300+
</RiskyTruthyFalsyComparison>
11961301
</file>
11971302
<file src="src/Utils/Error.php">
11981303
<PossiblyNullArgument>
@@ -1275,8 +1380,19 @@
12751380
<PossiblyInvalidIterator>
12761381
<code><![CDATA[$this->options['formats']]]></code>
12771382
</PossiblyInvalidIterator>
1383+
<RiskyTruthyFalsyComparison>
1384+
<code>$lineEnded</code>
1385+
<code><![CDATA[$this->options['clause_newline']]]></code>
1386+
<code><![CDATA[$this->options['parts_newline']]]></code>
1387+
<code><![CDATA[$this->options['parts_newline']]]></code>
1388+
<code><![CDATA[$this->options['parts_newline']]]></code>
1389+
<code><![CDATA[$this->options['remove_comments']]]></code>
1390+
</RiskyTruthyFalsyComparison>
12781391
</file>
12791392
<file src="src/Utils/Query.php">
1393+
<DocblockTypeContradiction>
1394+
<code><![CDATA[empty($parser->statements[0])]]></code>
1395+
</DocblockTypeContradiction>
12801396
<InvalidNullableReturnType>
12811397
<code>int</code>
12821398
</InvalidNullableReturnType>
@@ -1334,8 +1450,21 @@
13341450
<code>has</code>
13351451
<code>has</code>
13361452
</PossiblyNullReference>
1453+
<RiskyTruthyFalsyComparison>
1454+
<code><![CDATA[empty($expr->subquery)]]></code>
1455+
<code><![CDATA[empty($statement->group)]]></code>
1456+
<code><![CDATA[empty($statement->group)]]></code>
1457+
<code><![CDATA[empty($statement->having)]]></code>
1458+
<code><![CDATA[empty($statement->having)]]></code>
1459+
<code><![CDATA[empty($statement->join)]]></code>
1460+
<code><![CDATA[empty($statement->join)]]></code>
1461+
<code><![CDATA[empty($statement->order)]]></code>
1462+
</RiskyTruthyFalsyComparison>
13371463
</file>
13381464
<file src="src/Utils/Routine.php">
1465+
<DocblockTypeContradiction>
1466+
<code>empty($param[0])</code>
1467+
</DocblockTypeContradiction>
13391468
<MixedArgumentTypeCoercion>
13401469
<code>$options</code>
13411470
<code>$options</code>
@@ -1354,6 +1483,9 @@
13541483
<code>$options[]</code>
13551484
<code><![CDATA[$retval['opts'][$idx][]]]></code>
13561485
</MixedAssignment>
1486+
<RiskyTruthyFalsyComparison>
1487+
<code><![CDATA[empty($statement->parameters)]]></code>
1488+
</RiskyTruthyFalsyComparison>
13571489
</file>
13581490
<file src="src/Utils/Table.php">
13591491
<MixedArgument>
@@ -1381,6 +1513,10 @@
13811513
<code>has</code>
13821514
<code>has</code>
13831515
</PossiblyNullReference>
1516+
<RiskyTruthyFalsyComparison>
1517+
<code><![CDATA[empty($statement->fields)]]></code>
1518+
<code><![CDATA[empty($statement->fields)]]></code>
1519+
</RiskyTruthyFalsyComparison>
13841520
</file>
13851521
<file src="tests/Builder/AlterStatementTest.php">
13861522
<PossiblyUnusedMethod>
@@ -1648,6 +1784,9 @@
16481784
<PossiblyUnusedMethod>
16491785
<code>extractProvider</code>
16501786
</PossiblyUnusedMethod>
1787+
<RiskyTruthyFalsyComparison>
1788+
<code>$stmt</code>
1789+
</RiskyTruthyFalsyComparison>
16511790
</file>
16521791
<file src="tests/Utils/CLITest.php">
16531792
<PossiblyUnusedMethod>

0 commit comments

Comments
 (0)