QA_5_2: backport of phpmyadmin/phpmyadmin#12345 GD2 detection (use GD_MAJOR_VERSION)#19821
Merged
MauricioFauth merged 1 commit intophpmyadmin:QA_5_2from Aug 25, 2025
Conversation
Adapted from phpmyadmin#19820; replaces legacy checks, updates test, no functional change beyond precise version detection. Signed-off-by: Hendrik Becker <[email protected]>
MauricioFauth
approved these changes
Aug 23, 2025
Contributor
Author
|
CI failures look unrelated to these changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch GD2 detection to GD_MAJOR_VERSION (>=2); remove legacy
imagecreatetruecolor/gd_info/phpinfo checks and update tests.
Behavior unchanged, detection is just more precise.
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.