Improve detection of element in query#168
Merged
g105b merged 4 commits intophpgt:masterfrom Jun 8, 2022
Merged
Conversation
Member
|
Thank you @tfedor for this! It's a bug I've been wanting to resolve for a while. I will add a couple of extra tests that I identified from use in another project. Looks good so far. |
Member
|
After checking the failing test case on a real-world project I've been working on, it could be simply articulated by this single test I've added. The test simply looks for two named items within a form. Your bugfix resolves the issue that was present with this, so thank you very much. |
Alkarex
added a commit
to Alkarex/CssXPath
that referenced
this pull request
Aug 17, 2022
https://editorconfig.org/ This standard file inscructs text editors about the whitespace rules to use in any given project, so that contributors will automatically use the correct convention. I could see for instance that phpgt#168 introduced a mix of spaces and tabs
g105b
pushed a commit
that referenced
this pull request
Aug 17, 2022
https://editorconfig.org/ This standard file inscructs text editors about the whitespace rules to use in any given project, so that contributors will automatically use the correct convention. I could see for instance that #168 introduced a mix of spaces and tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #63, but also incorrect queries from selectors that combined multiple things, e.g. id and class, or class and attribute.