Add compatibility with symfony/process 8.0 #1134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @OndraM could you take a look, this will unlock lof of other projects :) |
|
The errors on the ci are the same as before. https://github.com/php-webdriver/php-webdriver/actions/runs/19982221867 symfony/process 8 installation is covered here In my point of view, the failing tests should be handled in seperated PRs. |
|
Hi, any updates on this? |
Collaborator
|
Hi, I will try to have a look next week 🙂 |
|
Thanks! |
|
Somehow this MR is more green: #1139 |
Basster
force-pushed
the
feature/symfony-8
branch
from
5f471e9 to
95cd023
Compare
Author
After rebase this PR is green, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of symfony 8, we can hopefully rely on symfony/process 8.x