array offset (level, message, context) should not be guarantee for hasRecord()#19
Merged
Seldaek merged 2 commits intophp-fig:mainfrom Nov 11, 2025
Merged
Conversation
sasezaki
changed the title
level, message, context) should not be guarantee for hasRecord()
mbabker
approved these changes
Oct 30, 2025
derrabus
approved these changes
Oct 31, 2025
Contributor
Author
|
Could anyone check this, please ? @Seldaek @Jean85 or other @php-fig members .. |
Seldaek
requested changes
Nov 10, 2025
src/Test/TestLogger.php
Outdated
| @@ -11,6 +11,7 @@ | |||
| * It records all records and gives you access to them for verification. | |||
| * | |||
| * @psalm-type log_record_array array{level: string, message: string|\Stringable, context: array{exception?: \Throwable}} | |||
Contributor
There was a problem hiding this comment.
Should not fix the context type here as well? It can contain more than exception
Contributor
Contributor
There was a problem hiding this comment.
Ah right thanks, let's merge this then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #18