Explain the signature of FrameInterface#807
Merged
shadowhand merged 2 commits intomasterfrom Aug 18, 2016
Merged
Conversation
This documentation is a transcript of the discussions in https://groups.google.com/d/topic/php-fig/V12AAcT_SxE/discussion and #755
| already use a class that implements `__invoke()` for the `$next` argument with | ||
| a different signature: `$request` *and* `$response`. Using the same method name | ||
| has the potential to make PSR-15 completely incompatible with these existing | ||
| systems without major changes. |
Contributor
There was a problem hiding this comment.
I'd maybe rephrase this last sentence to:
By selecting a different method, PSR-15 may be implemented within existing systems in parallel with existing features, providing a migration path for these libraries and their consumers. In some cases, existing
__invoke()implementations could even proxy to the method defined by PSR-15, or vice versa.
Contributor
|
Let me know when you feel it's ready and I'll approve. (Or @shadowhand can, as it's his baby.) |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documentation is a transcript of the discussions in https://groups.google.com/d/topic/php-fig/V12AAcT_SxE/discussion and #755