Fix deprecation notices#109
Merged
Merged
Conversation
add explicit nullable types
add explicit nullable type
Contributor
|
@rtheunissen This needs a tag, please. |
Contributor
|
Actually, this still isn't enough. Deprecated: Ds\Traits\GenericSequence::filter(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Traits/GenericSequence.php on line 99
Deprecated: Ds\Traits\GenericSequence::join(): Implicitly marking parameter $glue as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Traits/GenericSequence.php on line 162
Deprecated: Ds\Traits\GenericSequence::slice(): Implicitly marking parameter $length as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Traits/GenericSequence.php on line 321
Deprecated: Ds\Traits\GenericSequence::sort(): Implicitly marking parameter $comparator as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Traits/GenericSequence.php on line 333
Deprecated: Ds\Traits\GenericSequence::sorted(): Implicitly marking parameter $comparator as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Traits/GenericSequence.php on line 346
Deprecated: Ds\Sequence::filter(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Sequence.php on line 71
Deprecated: Ds\Sequence::join(): Implicitly marking parameter $glue as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Sequence.php on line 124
Deprecated: Ds\Sequence::slice(): Implicitly marking parameter $length as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Sequence.php on line 283
Deprecated: Ds\Sequence::sort(): Implicitly marking parameter $comparator as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Sequence.php on line 293
Deprecated: Ds\Sequence::sorted(): Implicitly marking parameter $comparator as nullable is deprecated, the explicit nullable type must be used instead in /vendor/php-ds/php-ds/src/Sequence.php on line 307Someone should really go through and actually fix all the occurrences of this deprecation notice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix
Implicitly marking parameter $param as nullable is deprecated, the explicit nullable type must be used insteadPHP 8.4 notices in Set and Map classes. Works towards #108Nullable type hinting came in in 7.1 so no need to update composer.json here as it's currently on 7.4 anyway