Fix incorrect return type description for Set#contains().#104
Merged
Conversation
rtheunissen
approved these changes
May 18, 2025
| * @return bool true if at least one value was provided and the set | ||
| * contains all given values, false otherwise. | ||
| * @return bool false if any of the provided values are not in the set; | ||
| * true otherwise. |
Member
There was a problem hiding this comment.
This is a correction, yes. I wonder if we should instead reason in the positive, in this case
@return bool true if all values exist in the set, or none given.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current return type description is confusing, since it implies that an empty
$valueswould cause the method to returnfalse, when in fact, it would returntrue.The corrected description is based on https://www.php.net/manual/en/ds-set.contains.php#refsect1-ds-set.contains-returnvalues