Skip to content
This repository was archived by the owner on Apr 9, 2026. It is now read-only.

Archive PHP 7.4 and 8.0#3

Merged
cmb69 merged 2 commits into
php:mainfrom
alcaeus:archive-old-php
Jul 8, 2024
Merged

Archive PHP 7.4 and 8.0#3
cmb69 merged 2 commits into
php:mainfrom
alcaeus:archive-old-php

Conversation

@alcaeus

@alcaeus alcaeus commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

Adding PHP 7.4 and 8.0 to the release list allows us to fetch these files directly from the archives without fetching releases.json beforehand. I also added some debug output that's helpful in case Invoke-WebRequest fails to download the file - it wasn't always obvious what download failed.

@cmb69

cmb69 commented Jul 8, 2024

Copy link
Copy Markdown
Member

Thank you!

I also added some debug output that's helpful in case Invoke-WebRequest fails to download the file - it wasn't always obvious what download failed.

I like that!

@cmb69
cmb69 merged commit 9cf03b8 into php:main Jul 8, 2024
@alcaeus
alcaeus deleted the archive-old-php branch July 8, 2024 12:11
@alcaeus

alcaeus commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for the quick merge. Can you tag v0.9?

@cmb69

cmb69 commented Jul 8, 2024

Copy link
Copy Markdown
Member

Can you tag v0.9?

I think we should also add support for PHP 8.4, which is supposed to be built with VS17, so besides some code additions, the README needs an update and there should be some tests. I'll try to see to that later today.

@alcaeus

alcaeus commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

Sounds good - I considered that for a moment but didn't know what VS version it needed and didn't find any files, so I skipped that part for now.

@cmb69

cmb69 commented Jul 10, 2024

Copy link
Copy Markdown
Member

Just to let you know, I didn't forget to tag 0.9, but are looking for some further clarifications, so this might take a couple of days.

@alcaeus

alcaeus commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

Just to let you know, I didn't forget to tag 0.9, but are looking for some further clarifications, so this might take a couple of days.

No worries - the current solution has our builds running, so no rush from my side!

@cmb69

cmb69 commented Jul 25, 2024

Copy link
Copy Markdown
Member

Finally, https://github.com/php/setup-php-sdk/releases/tag/v0.9 is available. \o/

@alcaeus

alcaeus commented Jul 25, 2024

Copy link
Copy Markdown
Contributor Author

Thank you!

cmb69 added a commit that referenced this pull request Sep 30, 2024
Besides a slight improvement to the error message, we also fix the
outdated documentation in README.md.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants