-
Notifications
You must be signed in to change notification settings - Fork 59
Incompatibilities with -dev PHP versions #535
Copy link
Copy link
Labels
bugSomething isn't workingSomething isn't workingmaintainer investigatingThis ticket is being investigated by maintainers. Please check with us before contributing PRs etc!This ticket is being investigated by maintainers. Please check with us before contributing PRs etc!
Milestone
Description
A couple of incompatibilities with -dev type PHP versions have been spotted; first, this test is stripping out the -dev version;
1) Php\PieUnitTest\DependencyResolver\FetchDependencyStatusesTest::testRequiresReturnsListOfStatuses
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'ext-core: == 8.5.5.0 ✅'
+'ext-core: == 8.5.5.0 🚫 (your version is 8.5.5.0-dev)'
Secondly, when we want to install bundled extensions, the -dev is stripped and we try to download a stable instead;
$ /home/james/workspace/oss/php-src-build/bin/php bin/pie install php/dom
🥧 PHP Installer for Extensions (PIE) 1.4.9999999.9999999-dev, from The PHP Foundation
This command may need elevated privileges, and may prompt you for your password.
You are running PHP 8.6.0-dev
Target PHP installation: 8.6.0 ts, on Linux/OSX/etc x86_64 (from /home/james/workspace/oss/php-src-build/bin/php)
Found package: php/dom:8.6.0 which provides ext-dom
In CurlDownloader.php line 671:
The "https://codeload.github.com/php/php-src/legacy.zip/php-8.6.0" file could not be downloaded (HTTP/2 404 )
install [-j|--make-parallel-jobs MAKE-PARALLEL-JOBS] [--skip-enable-extension] [--force] [-d|--working-dir WORKING-DIR] [--with-php-config WITH-PHP-CONFIG] [--with-php-path WITH-PHP-PATH] [--with-phpize-path WITH-PHPIZE-PATH] [--no-cache] [--allow-non-interactive-project-install] [--auto-install-build-tools] [--no-build-tools-check] [--auto-install-system-dependencies] [--no-system-dependencies-check] [--] [<requested-package-and-version>]
The second case may be something we just don't want to support; since if you're using a non-stable version of PHP you probably know how to bundle extensions up anyway; and in those cases, we would really need to get the exact commit/sha of what you built - which may not actually be correct, if you built from a php-src with uncommitted changes...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingmaintainer investigatingThis ticket is being investigated by maintainers. Please check with us before contributing PRs etc!This ticket is being investigated by maintainers. Please check with us before contributing PRs etc!