Closed
Conversation
hikari-no-yume
force-pushed
the
no_php4_constructors
branch
2 times, most recently
from
8fe8021 to
1790654
Compare
Contributor
Author
|
Note: |
hikari-no-yume
force-pushed
the
no_php4_constructors
branch
3 times, most recently
from
5fcb086 to
06019eb
Compare
Contributor
|
Breaks a ton of tests for SOAP - I guess it needs some work. |
Contributor
Author
|
@smalyshev Yes, that's the one thing I have left to do. |
Contributor
Author
|
There's an issue with session handlers not having their constructors called if they aren't PHP4-style (!). That'll need to be fixed. Otherwise, the patch is complete AFAIK. |
hikari-no-yume
force-pushed
the
no_php4_constructors
branch
from
9f08d65 to
db91bc5
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since @morrisonlevi doesn't have time to work on the patch himself, I'm doing it myself. His pull request is here: #901
This is a patch for the Remove PHP 4 Constructors RFC: https://wiki.php.net/rfc/remove_php4_constructors