Make exit() unwind properly (minimal version) #5768
Conversation
|
Thank you, I'm all in for an internal exception with no userland behaviour change. |
|
When control returns to an internal function, will |
Yes, it will be set. Internal functions will work correctly if they handle exceptions correctly (e.g., don't throw warnings if an exception has been thrown). |
|
@dstogov Do you see issues with this change? This internally implements exit with an exception, to make sure we go through clean shutdown, and don't leak any persistent resources, when exit it used. It's intended to have minimal impact on user-visible behavior. |
|
The idea looks fine, and I don't see any problems. |
…estructAfterConstructorExit` sniff
> If an object constructor exit()s, the object destructor will no longer be
> called. This matches the behavior when the constructor throws.
Notes:
* This sniff will throw an error, even when there is no destructor as a destructor may be declared in a parent class.
We could reduce the potential noise from this sniff a little further by only throwing the error when the class either contains a `__destruct()` method or extends a parent class.
* The name for the sniff feels a bit long. Suggestions for a better/shorter name welcome.
Opinions ?
Refs:
* https://github.com/php/php-src/blob/71bfa5344ab207072f4cd25745d7023096338385/UPGRADING#L200-L201
* php/php-src#5768 (I suspect, but not 100% sure)
* php/php-src@75a04ea
…estructAfterConstructorExit` sniff
> If an object constructor exit()s, the object destructor will no longer be
> called. This matches the behavior when the constructor throws.
Notes:
* This sniff will throw an error, even when there is no destructor as a destructor may be declared in a parent class.
We could reduce the potential noise from this sniff a little further by only throwing the error when the class either contains a `__destruct()` method or extends a parent class.
* The name for the sniff feels a bit long. Suggestions for a better/shorter name welcome.
Opinions ?
Refs:
* https://github.com/php/php-src/blob/71bfa5344ab207072f4cd25745d7023096338385/UPGRADING#L200-L201
* php/php-src#5768 (I suspect, but not 100% sure)
* php/php-src@75a04ea
3 participants
This is a minimal version of #5243. It switches exit() to throw an internal exception that is invisible to the user and only used to unwind the stack properly and perform a clean shutdown.
It does not execute finally block for exits, and leaves that issue for the future.