Skip to content

Comments

parse_url is inconsistent with specified port (#64604)#533

Closed
iwalz wants to merge 1 commit intophp:PHP-5.4from
iwalz:bugfix/64604
Closed

parse_url is inconsistent with specified port (#64604)#533
iwalz wants to merge 1 commit intophp:PHP-5.4from
iwalz:bugfix/64604

Conversation

@iwalz
Copy link
Contributor

@iwalz iwalz commented Nov 23, 2013

This is a basic fix for https://bugs.php.net/bug.php?id=64604
As discussed with @yohgaki in #509 a separate ticket will be opened for the TLD issue (see comments in the ticket) to identify the hostname and I'm going to ask in the internals mailinglist soon for opinions about possible solutions.

@mapthegod
Copy link

Die Zustellung an folgende Empfänger oder Gruppen verzögert sich:

[email protected]:[email protected]

Betreff: [php-src] parse_url is inconsistent with specified port (#64604) (#533)

Diese Nachricht wurde noch nicht zugestellt. Es wird weiterhin versucht, die Nachricht zuzustellen.

Der Server wird noch 2 Tage, 22 Stunden und 57 Minuten versuchen, die Nachricht zuzustellen. Sie erhalten eine Benachrichtigung, falls die Nachricht bis dahin nicht übermittelt werden konnte.

@kaplanlior kaplanlior mentioned this pull request Nov 23, 2013
@mapthegod
Copy link

Fehler bei der Nachrichtenzustellung an folgende Empfänger oder Gruppen:

[email protected]:[email protected]
Der Server konnte diese Nachricht nicht zustellen. Weitere Versuche werden nicht unternommen. Versuchen Sie, die Nachricht noch mal zu senden. Kontaktieren Sie bitte Helpdesk, wenn das Problem weiterhin auftritt.

Diagnoseinformationen für Administratoren:

Generierender Server: EXCHANGE02.justepic.info

[email protected]
#550 4.4.7 QUEUE.Expired; message expired ##rfc822;[email protected]

Ursprüngliche Nachrichtenköpfe:

Received: from EXCHANGE02.justepic.info (78.47.212.213) by
EXCHANGE02.justepic.info (78.47.212.213) with Microsoft SMTP Server (TLS) id
15.0.516.32; Sat, 23 Nov 2013 02:57:54 +0100
Received: from EXCHANGE02 (127.0.0.1) by EXCHANGE02.justepic.info (127.0.0.1)
with Microsoft SMTP Server id 15.0.516.32 via Frontend Transport; Sat, 23 Nov
2013 02:57:54 +0100
Delivered-To: [email protected]
Received: by 10.182.104.7 with SMTP id ga7csp282404obb; Fri, 22 Nov
2013 17:39:30 -0800 (PST)
X-Received: by 10.224.89.73 with SMTP id d9mr26826828qam.5.1385170770401;
Fri, 22 Nov 2013 17:39:30 -0800 (PST)
Return-Path: [email protected]
Received: from github-smtp2a-ext-cp1-prd.iad.github.net
(github-smtp2-ext1.iad.github.net. [192.30.252.192]) by mx.google.com
with ESMTPS id y5si847732qar.158.2013.11.22.17.39.30 for
[email protected] (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA
bits=128/128); Fri, 22 Nov 2013 17:39:30 -0800 (PST)
Received-SPF: pass (google.com: domain of [email protected] designates
192.30.252.192 as permitted sender) client-ip=192.30.252.192;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of
[email protected] designates 192.30.252.192 as permitted sender)
smtp.mail=[email protected]
Date: Fri, 22 Nov 2013 17:39:29 -0800
From: Ingo Walz [email protected]
Reply-To: php/php-src
[email protected]
To: php/php-src [email protected]
Message-ID: php/php-src/pull/[email protected]
Subject: [php-src] parse_url is inconsistent with specified port (#64604)
(#533)
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_52900751ef406_3aaf853cfc87590"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Recipient: mapthegod
List-ID: php/php-src <php-src.php.github.com>
List-Archive: https://github.com/php/php-src
List-Post: mailto:[email protected]
List-Unsubscribe: mailto:unsub+i-23178804-1b3b17c518c024a4461a50cddba4b1623d8b0608-2857983@reply.github.com,
https://github.com/notifications/unsubscribe/Fuv_XTp7qmdbI0HUfbErj5fOCWuB2JAfcHaRT1Qpfc4kdIOyQwruUZjSn6ymPxaI
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: [email protected]

@php-pulls
Copy link

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Apr 14, 2014
@smalyshev
Copy link
Contributor

Unfortunately, this patch seems to break parsing URLs like: /foo/bar?baz=goo:boo which returns false with it. I will have to revert it. I'll add a test case for the broken part and you are welcome to resubmit the fix after it is amended to not break this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants