Create str_contains PHP function by philippta · Pull Request #5179 · php/php-src

philippta · 2020-02-13T15:24:08Z

There is currently no function to check if a string contains another string. The only way to achive this behavior is to use other functions like strpos or strstr.

This type of function exists for example for arrays (in_array), while there is still array_search (equivalent to strpos) available.

I would like to propose the new function str_contains:

str_contains ( string $haystack , string $needle ) : bool

It takes a $haystack and $needle as a parameter and checks if the $haystack string contains the $needle string. It returns a boolean value (true/false) to indicate weather the $needle is found.

Example:

<?php

str_contains("abc", "a"); // true
str_contains("abc", "d"); // false

nikic

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).

philippta · 2020-02-14T08:35:11Z

I'm in favor, but this will need an RFC (https://wiki.php.net/rfc/howto).

This sounds great. I will go ahead and create an RFC for this.

jrbasso · 2020-02-16T02:52:51Z

To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.

Girgias · 2020-02-16T12:35:03Z

To avoid another PR/RFC, what do you think in including a str_icontains function too? Many of other str functions has the i version.

See https://externals.io/message/108562 as to why it doesn't make a lot of sense to include a case insensitive version.

philippta · 2020-02-17T11:39:34Z

An RFC has been created: https://wiki.php.net/rfc/str_contains

laruence · 2020-02-21T05:12:52Z

I am not sure what is the difference between this and if (strpos === false).

KennedyTedesco · 2020-02-21T13:35:30Z

To me, as a user, it is purely about UX. Having a str_contains it's better than using strpos.

lcobucci · 2020-03-03T08:10:09Z

Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time 👍

philippta · 2020-03-13T09:01:44Z

Could you please add a test covering the examples you have in the RFC? That would be quite good to ensure that things behave properly throughout time

Tests have been added.

Gemorroj · 2020-03-14T19:31:43Z

what about multibyte support?

// UTF-8
str_contains("тест", "т"); // ???

Girgias · 2020-03-14T19:33:29Z

what about multibyte support?
// UTF-8
str_contains("тест", "т"); // ???

That would return true

Gemorroj · 2020-03-14T19:44:45Z

@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");

str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool

or make new function str_icontains for case-insensitive cases

Girgias · 2020-03-14T19:51:43Z

@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool
or make new function str_icontains for case-insensitive cases

... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)
The RFC also says why it is not in the proposal: #5179 (comment)

Girgias · 2020-03-14T19:51:44Z

@Girgias maybe add third option for case-insensitive cases? str_contains("abc", "A");
str_contains ( string $haystack , string $needle, bool $caseInsensitive = false ) : bool
or make new function str_icontains for case-insensitive cases

... Have you read this PR thread and or the RFC? I've linked reasons as to why it doesn't make sense: #5179 (comment)
The RFC also says why it is not in the proposal: #5179 (comment)

Gemorroj · 2020-03-14T20:02:30Z

Have you read this PR thread and or the RFC?

No. But now yes. There are answers to all my questions. Thanks.
It would be good to specify a link to the RFC in the first post, so that there are no such misunderstandings.

philippta · 2020-03-16T09:46:14Z

The RFC has been accepted and the voting phase has been closed.
It is now ready to be merged.

scottchiefbaker · 2020-05-30T21:52:43Z

Are there official polyfills for the new this and the other new string functions?

Gemorroj · 2020-05-30T21:55:32Z

@scottchiefbaker https://github.com/symfony/polyfill-php80

scottchiefbaker · 2020-05-30T21:58:39Z

@Gemorroj perfect, thank you

leernd007 · 2020-06-03T16:50:37Z

I am not sure what is the difference between this and if (strpos === false).

Repurposing strpos and strstr for this use-case has a few down sides. Either, they are:

not very intuitive for a reader
easy to get wrong (especially with the !== comparison)
or hard to remember for new PHP developers.

https://wiki.php.net/rfc/str_contains

sfaut · 2020-07-13T23:12:17Z

I am not sure what is the difference between this and if (strpos === false).

Empty string management differs. strpos('foo', '') emits a warning and returns false.

When I search something I don't want always to have true returned in some cases. I think it is bug-compliant.

* RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches) * ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotion php/php-src#5291) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

dani7115 · 2022-05-07T08:42:40Z

I always wanted this, Since the day i started programming in PHP :) . Thanks Finally

Applied rules: * TokenGetAllToObjectRector (https://wiki.php.net/rfc/token_as_object) * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

Applied rules: * ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotion php/php-src#5291) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179) * ReadOnlyPropertyRector (https://wiki.php.net/rfc/readonly_properties_v2)

Applied rules: * LongArrayToShortArrayRector * TernaryToNullCoalescingRector * PublicConstantVisibilityRector (https://wiki.php.net/rfc/class_const_visibility) * ListToArrayDestructRector (https://wiki.php.net/rfc/short_list_syntax https://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring) * MixedTypeRector * StrContainsRector (https://externals.io/message/108562 php/php-src#5179) * ChangeSwitchToMatchRector (https://wiki.php.net/rfc/match_expression_v2) * FinalizePublicClassConstantRector (https://php.watch/versions/8.1/final-class-const) * NullToStrictStringFuncCallArgRector * TypedPropertyFromAssignsRector

nikic added the RFC label Feb 13, 2020

nikic reviewed Feb 13, 2020

View reviewed changes

Comment thread ext/standard/basic_functions_arginfo.h Outdated

philippta force-pushed the str_contains branch from 163c576 to 0de0e3d Compare February 14, 2020 08:12

Create str_contains php function

5994551

philippta force-pushed the str_contains branch from 0de0e3d to 5994551 Compare February 14, 2020 08:32

Add tests for str_contains() function

8a60b3c

philippta force-pushed the str_contains branch from 7711fad to 3ed6214 Compare March 13, 2020 09:02

Merge branch 'master' into str_contains

c31f57d

philippta force-pushed the str_contains branch from 3ed6214 to c31f57d Compare March 13, 2020 09:03

nikic approved these changes Mar 16, 2020

View reviewed changes

php-pulls closed this in 1668ad7 Mar 16, 2020

carusogabriel added this to the PHP 8.0 milestone May 29, 2020

franzholz mentioned this pull request Jan 15, 2022

PHP 8 rector recommended changes FriendsOfTYPO3/typo3db_legacy#21

Merged

kenjis mentioned this pull request Nov 29, 2022

refactor: upgrade to PHP 8.0 with rector codeigniter4/CodeIgniter4#6923

Closed

5 tasks

Conversation

philippta commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

philippta commented Feb 14, 2020

Uh oh!

jrbasso commented Feb 16, 2020

Uh oh!

Girgias commented Feb 16, 2020

Uh oh!

philippta commented Feb 17, 2020

Uh oh!

laruence commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KennedyTedesco commented Feb 21, 2020

Uh oh!

lcobucci commented Mar 3, 2020

Uh oh!

philippta commented Mar 13, 2020

Uh oh!

Gemorroj commented Mar 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Girgias commented Mar 14, 2020

Uh oh!

Gemorroj commented Mar 14, 2020

Uh oh!

Girgias commented Mar 14, 2020

Uh oh!

Girgias commented Mar 14, 2020

Uh oh!

Gemorroj commented Mar 14, 2020

Uh oh!

philippta commented Mar 16, 2020

Uh oh!

scottchiefbaker commented May 30, 2020

Uh oh!

Gemorroj commented May 30, 2020

Uh oh!

scottchiefbaker commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leernd007 commented Jun 3, 2020

Uh oh!

sfaut commented Jul 13, 2020

Uh oh!

dani7115 commented May 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

philippta commented Feb 13, 2020 •

edited

Loading

nikic left a comment •

edited

Loading

laruence commented Feb 21, 2020 •

edited

Loading

Gemorroj commented Mar 14, 2020 •

edited

Loading

scottchiefbaker commented May 30, 2020 •

edited

Loading