Closed
Conversation
TysonAndre
reviewed
Oct 2, 2019
| ZEND_ARG_INFO(0, y) | ||
| ZEND_END_ARG_INFO() | ||
|
|
||
| ZEND_BEGIN_ARG_INFO(arginfo_fdiv, 0) |
Contributor
There was a problem hiding this comment.
This looks like it could add Reflection param and return types, with/without being generated by stubs (some of the above functions already do)
$dividend and $divisor could be used as names to match intdiv.
Member
Author
There was a problem hiding this comment.
I expect that these functions will be converted to stubs very soon, so I'm leaving it for now.
bishopb
approved these changes
Oct 2, 2019
| #ifdef __clang__ | ||
| __attribute__((no_sanitize("float-divide-by-zero"))) | ||
| #endif | ||
| PHP_FUNCTION(fdiv) |
Contributor
There was a problem hiding this comment.
I recognize the etymology, but I wonder if floatdiv would be a more natural PHP name: it's verbose, and pairs with intdiv obviously. Said another way, the behavior seems closer to intdiv than fmod, so the name should be more closely aligned with the former (floatdiv) than the latter (fdiv).
There was a problem hiding this comment.
Said another way, the behavior seems closer to intdiv than fmod, so the name should be more closely aligned with the former (floatdiv) than the latter (fdiv).
That true, but if someone would ask me a question "What is a complementary (?) function to fmod?" my first guess would be fdiv. Just sharing my thoughs 😉
Member
Author
|
Merged as e35bdb4. |
19 tasks
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Mar 27, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Apr 9, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Apr 9, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Apr 9, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Apr 11, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Jul 15, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Jul 16, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Jul 17, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
jfcherng
added a commit
to jfcherng-sublime/ST-Official-Packages
that referenced
this pull request
Jul 21, 2020
php/php-src#4769 Signed-off-by: Jack Cherng <[email protected]>
wbond
pushed a commit
to sublimehq/Packages
that referenced
this pull request
Jul 21, 2020
* [PHP] Add some built-in classes and constants Classes: ArgumentCountError ArithmeticError CompileError DivisionByZeroError Error ParseError Stringable TypeError ValueError WeakMap WeakReference --- Constants: FILTER_VALIDATE_BOOL --- https://github.com/symfony/polyfill-php80 https://wiki.php.net/rfc/stringable https://wiki.php.net/rfc/weak_maps https://www.php.net/manual/en/reserved.exceptions.php https://www.php.net/manual/en/spl.exceptions.php * [PHP] Add support for union types https://wiki.php.net/rfc/union_types_v2 * [PHP] Add support for "static" return type https://wiki.php.net/rfc/static_return_type * [PHP] Add core function: str_contains https://wiki.php.net/rfc/str_contains * [PHP] Add core function: get_debug_type * [PHP] Add built-in class: DateTimeImmutable, DateTimeInterface * [PHP] Add core function: fdiv php/php-src#4769 * [PHP] Add built-in class: PhpToken https://wiki.php.net/rfc/token_as_object * [PHP] Add core function: str_starts_with, str_ends_with https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions * [PHP] Add support for short attributes ("@@") https://wiki.php.net/rfc/attributes_v2 https://wiki.php.net/rfc/attribute_amendments https://wiki.php.net/rfc/shorter_attribute_syntax * [PHP] Add support for "mixed" type hinting https://wiki.php.net/rfc/mixed_type_v2 * [PHP] Add support for constructor property promotion https://wiki.php.net/rfc/constructor_promotion * [PHP] Extract visibility modifier as a variable * [PHP] Add missing constant: DNS_CAA Fixes #991 * [PHP] Add support for "match" expression https://wiki.php.net/rfc/match_expression_v2 * [PHP] Add snippet: fn ... * [PHP] Add snippet: match ... * [PHP] Add support for named arguments https://wiki.php.net/rfc/named_params * [PHP] Add support for nullsafe operator https://wiki.php.net/rfc/nullsafe_operator * [PHP] Add core function: get_resource_id php/php-src#5427 * [PHP] Add built-in class: InternalIterator php/php-src#5216 * [PHP] Syntax definition use "version: 2" * [PHP] Fix punctuation scopes have no begin/end
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
* [PHP] Add some built-in classes and constants Classes: ArgumentCountError ArithmeticError CompileError DivisionByZeroError Error ParseError Stringable TypeError ValueError WeakMap WeakReference --- Constants: FILTER_VALIDATE_BOOL --- https://github.com/symfony/polyfill-php80 https://wiki.php.net/rfc/stringable https://wiki.php.net/rfc/weak_maps https://www.php.net/manual/en/reserved.exceptions.php https://www.php.net/manual/en/spl.exceptions.php * [PHP] Add support for union types https://wiki.php.net/rfc/union_types_v2 * [PHP] Add support for "static" return type https://wiki.php.net/rfc/static_return_type * [PHP] Add core function: str_contains https://wiki.php.net/rfc/str_contains * [PHP] Add core function: get_debug_type * [PHP] Add built-in class: DateTimeImmutable, DateTimeInterface * [PHP] Add core function: fdiv php/php-src#4769 * [PHP] Add built-in class: PhpToken https://wiki.php.net/rfc/token_as_object * [PHP] Add core function: str_starts_with, str_ends_with https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions * [PHP] Add support for short attributes ("@@") https://wiki.php.net/rfc/attributes_v2 https://wiki.php.net/rfc/attribute_amendments https://wiki.php.net/rfc/shorter_attribute_syntax * [PHP] Add support for "mixed" type hinting https://wiki.php.net/rfc/mixed_type_v2 * [PHP] Add support for constructor property promotion https://wiki.php.net/rfc/constructor_promotion * [PHP] Extract visibility modifier as a variable * [PHP] Add missing constant: DNS_CAA Fixes sublimehq#991 * [PHP] Add support for "match" expression https://wiki.php.net/rfc/match_expression_v2 * [PHP] Add snippet: fn ... * [PHP] Add snippet: match ... * [PHP] Add support for named arguments https://wiki.php.net/rfc/named_params * [PHP] Add support for nullsafe operator https://wiki.php.net/rfc/nullsafe_operator * [PHP] Add core function: get_resource_id php/php-src#5427 * [PHP] Add built-in class: InternalIterator php/php-src#5216 * [PHP] Syntax definition use "version: 2" * [PHP] Fix punctuation scopes have no begin/end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fdiv() function is part of the fmod() / intdiv() family. It implements a floating-point division with IEEE-754 semantics. That is, division by zero is considered well-defined and does not trigger any kind of diagnostic. Instead one of INF, -INF or NAN will be returned, depending on the case.
This is in preparation for throwing DivisionByZeroError from the standard division operator.