Convert dom methods arginfo to PHP stubs #4721
Conversation
beberlei
changed the title
|
Could you please rebase to resolve the merge conflicts? |
|
Niki also pointed me towards methods and return types, which in this case here need to be docblocks instead of real types. I will do the rebase as well. |
|
Test failures are legit. |
ext/dom/dom.stub.php
Outdated
| public function registerPhpFunctions($restrict = null) {} | ||
| } | ||
|
|
||
| function dom_import_simplexml(SimpleXMLElement $node): ?DOMElement {} |
There was a problem hiding this comment.
Does this throw is a non-SimpleXMLElement is passed?
There was a problem hiding this comment.
No, it just emits a warning :-/ What is the approach in that case?
There was a problem hiding this comment.
I'd relax the type to object for now.
|
As a followup, we should kill the use of FALIAS in dom. Those are not actually aliases. |
|
@nikic yes killing FALIAS is on my todo list. Its confusing |
beberlei
force-pushed
the
dom-arginfo-stubs
branch
from
ac0db42 to
4253ca4
Compare
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
I haven't rechecked everything ... gonna assume it's alright now ;)
5 participants
No description provided.