[RFC] Allow overriding abstract methods#2531
Closed
pmmaga wants to merge 1 commit into
Closed
Conversation
|
Thank you! ❤ |
nikic
reviewed
May 21, 2017
Member
There was a problem hiding this comment.
Maybe add two more test for the same with the signature being changed (in a compatible manner and an incompatible manner)?
Contributor
Author
There was a problem hiding this comment.
I've added those as well.
pmmaga
force-pushed
the
allow-abstract-function-override
branch
from
May 21, 2017 20:10
b208f6a to
2613609
Compare
pmmaga
force-pushed
the
allow-abstract-function-override
branch
from
May 21, 2017 20:16
2613609 to
8d3818f
Compare
nikic
approved these changes
May 24, 2017
Member
|
Merged as a5eb57c. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the RFC: https://wiki.php.net/rfc/allow-abstract-function-override
It also closes #63384