Conversation
|
Adam, just for curiosity, why not name it PDO::PARAM_FLOAT?, more readable than FLT |
|
I'd be happy to make the change. I was trying to have it be similar to STR and INT, but agree more readable would be better. |
|
Regarding NULL, agree it should probably be removed. Probably would be a straightforward RFC. Will add that to my todo list. :) |
|
Adam, what do you think on this? http://news.php.net/php.internals/99052 |
|
@adambaratz Just a gentle reminder that the respective RFC claims to be under discussion, but apparently there has not been any discussion for roughly two years. |
|
Thanks for the nudge. I had abandoned this RFC because of the level of disagreement around it, but forgot to do this clean up. |
|
@cmb69 I'm not sure why this PR was closed. This would have been a welcomed improvement to PDO. For example, the following statement can only return a string, bool, or integer when it is executed. Select :p0In order to get other types, one has to explicitly cast the value to a FLOAT, DOUBLE, DECIMAL, etc. While this PR was only for FLOATs, it undoubtedly highlights the need for additional types in PDO. |
The author withdrew the RFC, and accordingly closed this PR. From skimming the discussion, the controversial point was about fixed/numeric columns, which must not be handled as floating point values. Anyhow, if you are interested in reviving this, please pursue the RFC process. |
This is for discussion of a related RFC. Ignoring the notes about filling in test coverage, this is otherwise all that's needed to implement the feature (I've tested manually with most drivers).