Add digest algo param to OpenSSL public encrypt and private decrypt#19223
Closed
bukka wants to merge 1 commit intophp:masterfrom
Closed
Add digest algo param to OpenSSL public encrypt and private decrypt#19223bukka wants to merge 1 commit intophp:masterfrom
bukka wants to merge 1 commit intophp:masterfrom
Conversation
bukka
changed the title
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Jul 23, 2025
Specifically, it is added to openssl_public_encrypt() and openssl_private_decrypt() functions. The purpose is to specify digest algorithm for OEAP padding. It currently defaults to SHA1 which is not preferred for modern setup and causes problems in compatibility with web crypto. Closes phpGH-19223
bukka
force-pushed
the
openssl_private_encrypt_digest_algo
branch
from
cf85cba to
f02d3c7
Compare
Member
Author
|
As part of this I have been also trying to extend private encrypt (sign) and public decrypt (verify) but quickly realised the OEAP is not supported there so tried PSS (using |
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Jul 23, 2025
Specifically, it is added to openssl_public_encrypt() and openssl_private_decrypt() functions. The purpose is to specify digest algorithm for OEAP padding. It currently defaults to SHA1 which is not preferred for modern setup and causes problems in compatibility with web crypto. Closes phpGH-19223
bukka
force-pushed
the
openssl_private_encrypt_digest_algo
branch
from
f02d3c7 to
108c57a
Compare
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Jul 23, 2025
Specifically, it is added to openssl_public_encrypt() and openssl_private_decrypt() functions. The purpose is to specify digest algorithm for OEAP padding. It currently defaults to SHA1 which is not preferred for modern setup and causes problems in compatibility with web crypto. Closes phpGH-19223
bukka
force-pushed
the
openssl_private_encrypt_digest_algo
branch
from
108c57a to
4470ae6
Compare
ndossche
reviewed
Jul 24, 2025
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Jul 24, 2025
Specifically, it is added to openssl_public_encrypt() and openssl_private_decrypt() functions. The purpose is to specify digest algorithm for OEAP padding. It currently defaults to SHA1 for some OpenSSL versions which is not preferred for modern setup and causes problems in compatibility with web crypto. Closes phpGH-19223
bukka
force-pushed
the
openssl_private_encrypt_digest_algo
branch
from
4470ae6 to
a812af9
Compare
ndossche
approved these changes
Jul 25, 2025
ndossche
requested changes
Jul 25, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
ASAN reports a leak. Changes to NUL handling look correct.
ndossche
reviewed
Jul 25, 2025
Specifically, it is added to openssl_public_encrypt() and openssl_private_decrypt() functions. The purpose is to specify digest algorithm for OEAP padding. It currently defaults to SHA1 for some OpenSSL versions which is not preferred for modern setup and causes problems in compatibility with web crypto. Closes phpGH-19223
bukka
force-pushed
the
openssl_private_encrypt_digest_algo
branch
from
a812af9 to
f06382c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, it is added to openssl_public_encrypt() and openssl_private_decrypt() functions. The purpose is to specify digest algorithm for OEAP padding. It currently defaults to SHA1 for some OpenSSL versions / builds which is not preferred for modern setup and causes problems in compatibility with web crypto.