Fix reference access in dimensions for DOMNodeList and DOMNodeMap #13511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Feb 26, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Should their be a test for a ref to an int?
| bool(true) | ||
| string(3) "bar" | ||
|
|
||
| Warning: Attempt to read property "value" on null in %s on line %d |
Member
There was a problem hiding this comment.
Isn't this warning kinda confusing?
Member
Author
There was a problem hiding this comment.
Yeah, it's because the lookup returns NULL, but at least for this test I can adapt the test so it's less confusing.
Member
Author
Should be fine as it does the get_long call from the engine but I'll add a test anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.