ext/gmp: Make GMP class final (#15121)

Girgias · petk · web-flow · commit a50adda19e69 · 2024-07-28T13:03:26.000+01:00
* ext/gmp: Make GMP class final RFC: https://wiki.php.net/rfc/gmp-final * Update UPGRADING Co-authored-by: Peter Kokot <peterkokot@gmail.com> --------- Co-authored-by: Peter Kokot <peterkokot@gmail.com>
diff --git a/NEWS b/NEWS
@@ -21,6 +21,9 @@ PHP                                                                        NEWS
   . /dev/poll events.mechanism for Solaris/Illumos setting had been retired.
     (David Carlier)
 
+- GMP:
+  . The GMP class is now final and cannot be extended anymore.
+
 - Intl:
   . Added SpoofChecker::setAllowedChars to set unicode chars ranges.
     (David Carlier)
diff --git a/UPGRADING b/UPGRADING
@@ -48,6 +48,10 @@ PHP 8.4 UPGRADE NOTES
     object. This is no longer possible, and cloning a DOMXPath object now throws
     an error.
 
+- GMP:
+  . The GMP class is now final and cannot be extended anymore.
+    RFC: https://wiki.php.net/rfc/gmp-final
+
 - Intl:
   . resourcebundle_get(), ResourceBundle::get(), and accessing offsets on a
     ResourceBundle object now throw:
diff --git a/ext/gmp/gmp.stub.php b/ext/gmp/gmp.stub.php
@@ -57,7 +57,7 @@
  */
 const GMP_NATIVE_ENDIAN = UNKNOWN;
 
-class GMP
+final class GMP
 {
     public function __construct(int|string $num = 0, int $base = 0) {}
 
diff --git a/ext/gmp/gmp_arginfo.h b/ext/gmp/gmp_arginfo.h
diff --git a/ext/gmp/tests/final.phpt b/ext/gmp/tests/final.phpt
@@ -0,0 +1,12 @@
+--TEST--
+Cannot extend GMP class
+--EXTENSIONS--
+gmp
+--FILE--
+<?php
+
+class T extends GMP {}
+
+?>
+--EXPECTF--
+Fatal error: Class T cannot extend final class GMP in %s on line %d

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@`
`57`	`57`	`*/`
`58`	`58`	`const GMP_NATIVE_ENDIAN = UNKNOWN;`
`59`	`59`
`60`		`-class GMP`
	`60`	`+final class GMP`
`61`	`61`	`{`
`62`	`62`	`public function __construct(int\|string $num = 0, int $base = 0) {}`
`63`	`63`